浏览代码

LibWeb: Fix crash when loading a HTML string that contains an iframe

The HTMLIFrameElement does not create the nested browsing context on
insertion if the document does not have browsing context, which is not
set unless it's the active document.

Previously, in FrameLoader the document was not set as active until
after parsing, which led to iframes without nested browsing contexts,
and crashes.

Fixes #14207
MacDue 2 年之前
父节点
当前提交
e852aff9e3
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      Userland/Libraries/LibWeb/Loader/FrameLoader.cpp

+ 1 - 1
Userland/Libraries/LibWeb/Loader/FrameLoader.cpp

@@ -317,10 +317,10 @@ void FrameLoader::load_html(StringView html, const AK::URL& url)
         DOM::Document::Type::HTML,
         "text/html",
         move(navigation_params));
+    browsing_context().set_active_document(document);
 
     auto parser = HTML::HTMLParser::create(document, html, "utf-8");
     parser->run(url);
-    browsing_context().set_active_document(parser->document());
 }
 
 static String s_error_page_url = "file:///res/html/error.html";