We use cookies to ensure you get the best experience on our website
Home Explore Help
Register Sign In
0ct0pu5
/
ladybird
1
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

LibWeb: Ensure `document.getElementsByName("")` returns no elements

Previously, if a document had any element with a name attribute that
was  set to the empty string, then `document.getElementsByName("")` and
`element.getElementsByName("")` would return a collection including
those elements.
Tim Ledbetter 11 months ago
parent
0fceede029
commit
e40352b6b5
3 changed files with 10 additions and 1 deletions
Unified View Show Diff Stats
  1. 1 0
      Tests/LibWeb/Text/expected/DOM/getElementsName-empty-string.txt
  2. 8 0
      Tests/LibWeb/Text/input/DOM/getElementsName-empty-string.html
  3. 1 1
      Userland/Libraries/LibWeb/DOM/Element.cpp

+ 1 - 0
Tests/LibWeb/Text/expected/DOM/getElementsName-empty-string.txt
View File 

@@ -0,0 +1 @@
 
+  document.getElementsByName("").length: 0

+ 8 - 0
Tests/LibWeb/Text/input/DOM/getElementsName-empty-string.html
View File 

@@ -0,0 +1,8 @@
 
+<!DOCTYPE html>
 
+<script src="../include.js"></script>
 
+<div name=""></div>
 
+<script>
 
+    test(() => {
 
+        println(`document.getElementsByName("").length: ${document.getElementsByName("").length}`);
 
+    });
 
+</script>

+ 1 - 1
Userland/Libraries/LibWeb/DOM/Element.cpp
View File 

@@ -464,7 +464,7 @@ void Element::attribute_changed(FlyString const& name, Optional<String> const&,
 
 
 
         document().element_id_changed({}, *this);
 
         document().element_id_changed({}, *this);
 
     } else if (name == HTML::AttributeNames::name) {
 
     } else if (name == HTML::AttributeNames::name) {
 
-        if (!value.has_value())
 
+        if (value_or_empty.is_empty())
 
             m_name = {};
 
             m_name = {};
 
         else
 
         else
 
             m_name = value_or_empty;
 
             m_name = value_or_empty;

Contact | Legal | Takedown | Status
Self-hosted public services - About
NibbleSpot by 0ct0pu5