0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Kernel: Send SIGCHLD to the parent process when changing stopped state

Browse source 
This is done also by linux (signal.c:936 in v5.11) at least.
It's a pretty handy notification that allows the parent process to skip
going through a `waitpid` and guesswork to figure out the current state
of a child process.
This commit is contained in:
AnotherTest 2021-03-30 02:42:51 +04:30 • committed by Andreas Kling
parent 47080941cc
commit e3fd914187
Notes: sideshowbarker 2024-07-18 20:56:08 +09:00
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Kernel/Thread.cpp
View file

@ -911,6 +911,10 @@ void Thread::set_state(State new_state, u8 stop_signal)
return IterationDecision::Continue;
});
process.unblock_waiters(Thread::WaitBlocker::UnblockFlags::Continued);
// Tell the parent process (if any) about this change.
if (auto parent = Process::from_pid(process.ppid())) {
[[maybe_unused]] auto result = parent->send_signal(SIGCHLD, &process);
}
}
}
@ -930,6 +934,10 @@ void Thread::set_state(State new_state, u8 stop_signal)
return IterationDecision::Continue;
});
process.unblock_waiters(Thread::WaitBlocker::UnblockFlags::Stopped, stop_signal);
// Tell the parent process (if any) about this change.
if (auto parent = Process::from_pid(process.ppid())) {
[[maybe_unused]] auto result = parent->send_signal(SIGCHLD, &process);
}
}
} else if (m_state == Dying) {
VERIFY(previous_state != Blocked);