0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibJS: Make JS::Value constructors take const cell pointers

Browse source 
Taking non-const cell pointers is asking for trouble, since passing e.g
a "const Object*" to Value(Object*) will actually call Value(bool),
which is most likely not what you want.
This commit is contained in:
Andreas Kling 2020-11-28 15:57:25 +01:00
parent d617120499
commit e1bbc7c075
Notes: sideshowbarker 2024-07-19 01:13:04 +09:00
1 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
Libraries/LibJS/Runtime/Value.h
View file

@ -120,40 +120,40 @@ public:
m_value.as_double = value;
}
Value(Object* object)
Value(const Object* object)
: m_type(object ? Type::Object : Type::Null)
{
m_value.as_object = object;
m_value.as_object = const_cast<Object*>(object);
}
Value(PrimitiveString* string)
Value(const PrimitiveString* string)
: m_type(Type::String)
{
m_value.as_string = string;
m_value.as_string = const_cast<PrimitiveString*>(string);
}
Value(Symbol* symbol)
Value(const Symbol* symbol)
: m_type(Type::Symbol)
{
m_value.as_symbol = symbol;
m_value.as_symbol = const_cast<Symbol*>(symbol);
}
Value(Accessor* accessor)
Value(const Accessor* accessor)
: m_type(Type::Accessor)
{
m_value.as_accessor = accessor;
m_value.as_accessor = const_cast<Accessor*>(accessor);
}
Value(BigInt* bigint)
Value(const BigInt* bigint)
: m_type(Type::BigInt)
{
m_value.as_bigint = bigint;
m_value.as_bigint = const_cast<BigInt*>(bigint);
}
Value(NativeProperty* native_property)
Value(const NativeProperty* native_property)
: m_type(Type::NativeProperty)
{
m_value.as_native_property = native_property;
m_value.as_native_property = const_cast<NativeProperty*>(native_property);
}
explicit Value(Type type)