Przeglądaj źródła

LibCore: Remove unnecessary or invalid write after child remove

MINAqwq 1 rok temu
rodzic
commit
e1598233e1
1 zmienionych plików z 3 dodań i 1 usunięć
  1. 3 1
      Userland/Libraries/LibCore/EventReceiver.h

+ 3 - 1
Userland/Libraries/LibCore/EventReceiver.h

@@ -134,7 +134,9 @@ public:
     {
     {
         if (m_parent)
         if (m_parent)
             m_parent->remove_child(*this);
             m_parent->remove_child(*this);
-        m_parent = nullptr;
+
+        // The call to `remove_child` may have deleted the object.
+        // Do not dereference `this` from this point forward.
     }
     }
 
 
     template<class T, class... Args>
     template<class T, class... Args>