Parcourir la source

LibX86: Don't assert just because insn has no immediate bytes

It's perfectly fine to not have immediate bytes. Many insns don't :^)
Andreas Kling il y a 4 ans
Parent
commit
de149dc7fa
1 fichiers modifiés avec 4 ajouts et 2 suppressions
  1. 4 2
      Userland/Libraries/LibX86/Instruction.h

+ 4 - 2
Userland/Libraries/LibX86/Instruction.h

@@ -864,7 +864,8 @@ ALWAYS_INLINE Instruction::Instruction(InstructionStreamType& stream, bool o32,
         m_imm2 = stream.read32();
         break;
     default:
-        ASSERT_NOT_REACHED();
+        ASSERT(imm2_bytes == 0);
+        break;
     }
 
     switch (imm1_bytes) {
@@ -878,7 +879,8 @@ ALWAYS_INLINE Instruction::Instruction(InstructionStreamType& stream, bool o32,
         m_imm1 = stream.read32();
         break;
     default:
-        ASSERT_NOT_REACHED();
+        ASSERT(imm1_bytes == 0);
+        break;
     }
 
     m_extra_bytes = prefix_bytes + imm1_bytes + imm2_bytes;