0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Meta: Use namespaced JS::call invocations in IDLGenerators

Browse source 
When experimenting with different inheritance structures, I ended up
seeing compilation failures whenever a parent class defined a `call`
method. This seems more in line with the rest of the code.
This commit is contained in:
Jelle Raaijmakers 2024-11-26 11:44:31 +01:00 • committed by Tim Ledbetter
parent 872a214f80
commit db43ed03a8
Notes: github-actions[bot] 2024-11-26 12:45:07 +00:00
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp
View file

@ -4022,7 +4022,7 @@ JS_DEFINE_NATIVE_FUNCTION(@class_name@::for_each)
generate_variable_statement(iterator_generator, "wrapped_key", interface.pair_iterator_types->get<0>(), "key", interface);
generate_variable_statement(iterator_generator, "wrapped_value", interface.pair_iterator_types->get<1>(), "value", interface);
iterator_generator.append(R"~~~(
TRY(call(vm, callback.as_function(), vm.argument(1), wrapped_value, wrapped_key, this_value));
TRY(JS::call(vm, callback.as_function(), vm.argument(1), wrapped_value, wrapped_key, this_value));
return {};
}));
@ -4100,7 +4100,7 @@ JS_DEFINE_NATIVE_FUNCTION(@class_name@::for_each)
for (auto& entry : *set) {
auto value = entry.key;
TRY(call(vm, callback.as_function(), vm.argument(1), value, value, impl));
TRY(JS::call(vm, callback.as_function(), vm.argument(1), value, value, impl));
}
return JS::js_undefined();