浏览代码

gzip: Use utilities from LibCompress to (de)compress files

Timothy Flynn 2 年之前
父节点
当前提交
da6f32e5d8
共有 1 个文件被更改,包括 4 次插入14 次删除
  1. 4 14
      Userland/Utilities/gzip.cpp

+ 4 - 14
Userland/Utilities/gzip.cpp

@@ -41,27 +41,17 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
             output_filename = DeprecatedString::formatted("{}.gz", input_filename);
         }
 
-        // We map the whole file instead of streaming to reduce size overhead (gzip header) and increase the deflate block size (better compression)
-        // TODO: automatically fallback to buffered streaming for very large files
-        RefPtr<Core::MappedFile> file;
-        ReadonlyBytes input_bytes;
-        if (TRY(Core::System::stat(input_filename)).st_size > 0) {
-            file = TRY(Core::MappedFile::map(input_filename));
-            input_bytes = file->bytes();
-        }
+        auto output_stream = write_to_stdout ? TRY(Core::File::standard_output()) : TRY(Core::File::open(output_filename, Core::File::OpenMode::Write));
 
-        ByteBuffer output_bytes;
         if (decompress)
-            output_bytes = TRY(Compress::GzipDecompressor::decompress_all(input_bytes));
+            TRY(Compress::GzipDecompressor::decompress_file(input_filename, move(output_stream)));
         else
-            output_bytes = TRY(Compress::GzipCompressor::compress_all(input_bytes));
-
-        auto output_stream = write_to_stdout ? TRY(Core::File::standard_output()) : TRY(Core::File::open(output_filename, Core::File::OpenMode::Write));
-        TRY(output_stream->write_until_depleted(output_bytes));
+            TRY(Compress::GzipCompressor::compress_file(input_filename, move(output_stream)));
 
         if (!keep_input_files) {
             TRY(Core::System::unlink(input_filename));
         }
     }
+
     return 0;
 }