Browse Source

Kernel: Check kernel symbol's name length matches searched name

The current implementation would only check the first name.length()
characters match, which means any kernel symbol that the provided name
is a prefix of would match, instead of the actual matching symbol.

This commit fixes that by using StringView::operator==() for the
comparison, which already checks the equality correctly.
Idan Horowitz 4 years ago
parent
commit
d9f7b29273
1 changed files with 3 additions and 2 deletions
  1. 3 2
      Kernel/KSyms.cpp

+ 3 - 2
Kernel/KSyms.cpp

@@ -32,8 +32,9 @@ static u8 parse_hex_digit(char nibble)
 FlatPtr address_for_kernel_symbol(const StringView& name)
 FlatPtr address_for_kernel_symbol(const StringView& name)
 {
 {
     for (size_t i = 0; i < s_symbol_count; ++i) {
     for (size_t i = 0; i < s_symbol_count; ++i) {
-        if (!strncmp(name.characters_without_null_termination(), s_symbols[i].name, name.length()))
-            return s_symbols[i].address;
+        const auto& symbol = s_symbols[i];
+        if (name == symbol.name)
+            return symbol.address;
     }
     }
     return 0;
     return 0;
 }
 }