Преглед изворни кода

LibIDL: Fix accidental early return in resolve_typedef()

This made sense before we had the next step to resolve union types, but
now we only need to skip transferring the extended attributes, without
returning just yet.
Linus Groh пре 2 година
родитељ
комит
d9cb7b6dc7
1 измењених фајлова са 4 додато и 4 уклоњено
  1. 4 4
      Userland/Libraries/LibIDL/IDLParser.cpp

+ 4 - 4
Userland/Libraries/LibIDL/IDLParser.cpp

@@ -831,10 +831,10 @@ static void resolve_typedef(Interface& interface, NonnullRefPtr<Type>& type, Has
     bool nullable = type->is_nullable();
     type = it->value.type;
     type->set_nullable(nullable);
-    if (!extended_attributes)
-        return;
-    for (auto& attribute : it->value.extended_attributes)
-        extended_attributes->set(attribute.key, attribute.value);
+    if (extended_attributes) {
+        for (auto& attribute : it->value.extended_attributes)
+            extended_attributes->set(attribute.key, attribute.value);
+    }
 
     // Recursively resolve typedefs in unions after we resolved the type itself - e.g. for this:
     // typedef (A or B) Union1;