Kaynağa Gözat

LibWeb/Streams: Make ReadIntoRequest GC-allocated

This ports the same change which was made in 9c3e9e89816 to
ReadRequest, although nothing actually implements this interface yet.
Shannon Booth 1 yıl önce
ebeveyn
işleme
d81b0e3c86

+ 2 - 0
Userland/Libraries/LibWeb/Streams/ReadableStreamBYOBReader.cpp

@@ -45,6 +45,8 @@ void ReadableStreamBYOBReader::visit_edges(Cell::Visitor& visitor)
 {
     Base::visit_edges(visitor);
     ReadableStreamGenericReaderMixin::visit_edges(visitor);
+    for (auto& request : m_read_into_requests)
+        visitor.visit(request);
 }
 
 }

+ 5 - 3
Userland/Libraries/LibWeb/Streams/ReadableStreamBYOBReader.h

@@ -16,7 +16,9 @@
 namespace Web::Streams {
 
 // https://streams.spec.whatwg.org/#read-into-request
-class ReadIntoRequest : public RefCounted<ReadIntoRequest> {
+class ReadIntoRequest : public JS::Cell {
+    JS_CELL(ReadIntoRequest, JS::Cell);
+
 public:
     virtual ~ReadIntoRequest() = default;
 
@@ -43,7 +45,7 @@ public:
 
     void release_lock();
 
-    Vector<NonnullRefPtr<ReadIntoRequest>>& read_into_requests() { return m_read_into_requests; }
+    Vector<JS::NonnullGCPtr<ReadIntoRequest>>& read_into_requests() { return m_read_into_requests; }
 
 private:
     explicit ReadableStreamBYOBReader(JS::Realm&);
@@ -52,7 +54,7 @@ private:
 
     // https://streams.spec.whatwg.org/#readablestreambyobreader-readintorequests
     // A list of read-into requests, used when a consumer requests chunks sooner than they are available
-    Vector<NonnullRefPtr<ReadIntoRequest>> m_read_into_requests;
+    Vector<JS::NonnullGCPtr<ReadIntoRequest>> m_read_into_requests;
 };
 
 }