Browse Source

LibGfx/TIFF: Enforce a length of one for more tags

The TIFF spec is constructed in a way that many tags are defined in
multiple places but some of these definitions are partial. If we look
into "Section 8: Baseline Field Reference Guide", we can see that these
tags indeed have an enforced length of 1.
Lucas CHOLLET 1 year ago
parent
commit
d66a421757
1 changed files with 4 additions and 4 deletions
  1. 4 4
      Userland/Libraries/LibGfx/TIFFGenerator.py

+ 4 - 4
Userland/Libraries/LibGfx/TIFFGenerator.py

@@ -118,11 +118,11 @@ known_tags: List[Tag] = [
     Tag('277', [TIFFType.UnsignedShort], [1], None, "SamplesPerPixel", is_required=True),
     Tag('277', [TIFFType.UnsignedShort], [1], None, "SamplesPerPixel", is_required=True),
     Tag('278', [TIFFType.UnsignedShort, TIFFType.UnsignedLong], [1], None, "RowsPerStrip", is_required=True),
     Tag('278', [TIFFType.UnsignedShort, TIFFType.UnsignedLong], [1], None, "RowsPerStrip", is_required=True),
     Tag('279', [TIFFType.UnsignedShort, TIFFType.UnsignedLong], [], None, "StripByteCounts", is_required=True),
     Tag('279', [TIFFType.UnsignedShort, TIFFType.UnsignedLong], [], None, "StripByteCounts", is_required=True),
-    Tag('282', [TIFFType.UnsignedRational], [], None, "XResolution"),
-    Tag('283', [TIFFType.UnsignedRational], [], None, "YResolution"),
-    Tag('284', [TIFFType.UnsignedShort], [], PlanarConfiguration.Chunky, "PlanarConfiguration", PlanarConfiguration),
+    Tag('282', [TIFFType.UnsignedRational], [1], None, "XResolution"),
+    Tag('283', [TIFFType.UnsignedRational], [1], None, "YResolution"),
+    Tag('284', [TIFFType.UnsignedShort], [1], PlanarConfiguration.Chunky, "PlanarConfiguration", PlanarConfiguration),
     Tag('285', [TIFFType.ASCII], [], None, "PageName"),
     Tag('285', [TIFFType.ASCII], [], None, "PageName"),
-    Tag('296', [TIFFType.UnsignedShort], [], ResolutionUnit.Inch, "ResolutionUnit", ResolutionUnit),
+    Tag('296', [TIFFType.UnsignedShort], [1], ResolutionUnit.Inch, "ResolutionUnit", ResolutionUnit),
     Tag('339', [TIFFType.UnsignedShort], [], SampleFormat.Unsigned, "SampleFormat", SampleFormat),
     Tag('339', [TIFFType.UnsignedShort], [], SampleFormat.Unsigned, "SampleFormat", SampleFormat),
     Tag('317', [TIFFType.UnsignedShort], [1], Predictor.NoPrediction, "Predictor", Predictor),
     Tag('317', [TIFFType.UnsignedShort], [1], Predictor.NoPrediction, "Predictor", Predictor),
     Tag('320', [TIFFType.UnsignedShort], [], None, "ColorMap"),
     Tag('320', [TIFFType.UnsignedShort], [], None, "ColorMap"),