We use cookies to ensure you get the best experience on our website
Inicio Explorar Axuda
Rexistro Iniciar sesión
0ct0pu5
/
ladybird
1
0
Fork 0
Ficheiros Incidencias 0 Pull Requests 0 Wiki
Explorar o código

LibWeb: Shift SVG paintable clip rectangle by scroll offset

Rectangles should be recorded using absolute coordinates, including
the scroll offset.
Aliaksandr Kalenik hai 1 ano
pai
677bcea771
achega
d43dbe2842
Modificáronse 3 ficheiros con 50 adicións e 1 borrados
Unificar vista Mostrar estatísticas de Diff
  1. 15 0
      Tests/LibWeb/Ref/reference/svg-inside-scroll-container-ref.html
  2. 32 0
      Tests/LibWeb/Ref/svg-inside-scroll-container.html
  3. 3 1
      Userland/Libraries/LibWeb/Painting/SVGSVGPaintable.cpp

+ 15 - 0
Tests/LibWeb/Ref/reference/svg-inside-scroll-container-ref.html
Ver ficheiro 

@@ -0,0 +1,15 @@
 
+<!DOCTYPE html>
 
+<style>
 
+    svg {
 
+        display: block;
 
+    }
 
+</style>
 
+<svg width="100" height="100">
 
+    <rect width="100" height="100" fill="green" />
 
+</svg>
 
+<svg width="100" height="100">
 
+    <rect width="100" height="100" fill="green" />
 
+</svg>
 
+<svg width="100" height="100">
 
+    <rect width="100" height="100" fill="green" />
 
+</svg>

+ 32 - 0
Tests/LibWeb/Ref/svg-inside-scroll-container.html
Ver ficheiro 

@@ -0,0 +1,32 @@
 
+<!DOCTYPE html>
 
+<link rel="match" href="reference/svg-inside-scroll-container-ref.html" />
 
+<style>
 
+    #scrollable {
 
+        height: 300px;
 
+        overflow: scroll;
 
+    }
 
+    svg {
 
+        display: block;
 
+    }
 
+</style>
 
+<div id="scrollable">
 
+    <svg width="100" height="100">
 
+        <rect width="100" height="100" fill="green" />
 
+    </svg>
 
+    <svg width="100" height="100">
 
+        <rect width="100" height="100" fill="green" />
 
+    </svg>
 
+    <svg width="100" height="100">
 
+        <rect width="100" height="100" fill="green" />
 
+    </svg>
 
+    <svg width="100" height="100">
 
+        <rect width="100" height="100" fill="green" />
 
+    </svg>
 
+    <svg width="100" height="100">
 
+        <rect width="100" height="100" fill="green" />
 
+    </svg>
 
+</div>
 
+<script>
 
+    const scrollContainer = document.getElementById("scrollable");
 
+    scrollContainer.scrollTop = 100;
 
+</script>

+ 3 - 1
Userland/Libraries/LibWeb/Painting/SVGSVGPaintable.cpp
Ver ficheiro 

@@ -30,7 +30,9 @@ void SVGSVGPaintable::before_children_paint(PaintContext& context, PaintPhase ph
 
     if (phase != PaintPhase::Foreground)
 
     if (phase != PaintPhase::Foreground)
 
         return;
 
         return;
 
     context.recording_painter().save();
 
     context.recording_painter().save();
 
-    context.recording_painter().add_clip_rect(context.enclosing_device_rect(absolute_rect()).to_type<int>());
 
+    auto clip_rect = absolute_rect();
 
+    clip_rect.translate_by(enclosing_scroll_frame_offset().value_or({}));
 
+    context.recording_painter().add_clip_rect(context.enclosing_device_rect(clip_rect).to_type<int>());
 
 }
 
 }
 
 
 
 void SVGSVGPaintable::after_children_paint(PaintContext& context, PaintPhase phase) const
 
 void SVGSVGPaintable::after_children_paint(PaintContext& context, PaintPhase phase) const

Contact | Legal | Takedown | Status
Self-hosted public services - About
NibbleSpot by 0ct0pu5