AK: Add FIXMEs to HashMap copy-construct and copy-assign

This underlines that we still copy-construct and copy-assign HashMaps. Primarily, this makes it easier to develop towards OOM-safe(r) internal data structures, by providing a reminder (the FIXME) and an easy error- checking switch (just change it to "delete" to see some of the errors).
Author: https://github.com/BenWiederhake Commit: https://github.com/SerenityOS/serenity/commit/d43d51eedc Pull-request: https://github.com/SerenityOS/serenity/pull/18821 Reviewed-by: https://github.com/awesomekling Reviewed-by: https://github.com/gmta ✅ Reviewed-by: https://github.com/kleinesfilmroellchen ✅
2023-05-07 23:39:33 +02:00 · 2023-05-07 23:39:33 +02:00 · d43d51eedc · 2024-07-17 02:23:25 +09:00
commit d43d51eedc
parent 12d1ddbde5
1 changed files with 5 additions and 0 deletions
--- a/AK/HashMap.h
+++ b/AK/HashMap.h
@ -40,6 +40,11 @@ public:
            set(item.key, item.value);
    }

+    HashMap(HashMap const&) = default; // FIXME: Not OOM-safe! Use clone() instead.
+    HashMap(HashMap&& other) noexcept = default;
+    HashMap& operator=(HashMap const& other) = default; // FIXME: Not OOM-safe! Use clone() instead.
+    HashMap& operator=(HashMap&& other) noexcept = default;
+
    [[nodiscard]] bool is_empty() const
    {
        return m_table.is_empty();