0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibWeb: Handle inline-start and inline-end as float values

Browse source 
Should resolve #449 for LTR languages at least
This commit is contained in:
Colin Reeder 2024-07-06 15:31:28 -06:00 • committed by Andreas Kling
parent 11039085d0
commit d427344f39
Notes: sideshowbarker 2024-07-17 02:23:25 +09:00
5 changed files with 58 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
Tests/LibWeb/Layout/expected/block-and-inline/float-logical.txt Normal file
View file

@ -0,0 +1,17 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x60 [BFC] children: not-inline
BlockContainer <(anonymous)> at (0,0) content-size 800x0 children: inline
TextNode <#text>
BlockContainer <body> at (8,8) content-size 784x0 children: inline
TextNode <#text>
BlockContainer <div#b> at (9,9) content-size 50x50 floating [BFC] children: not-inline
TextNode <#text>
BlockContainer <div#c> at (741,9) content-size 50x50 floating [BFC] children: not-inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x60]
PaintableWithLines (BlockContainer(anonymous)) [0,0 800x0]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x0]
PaintableWithLines (BlockContainer<DIV>#b) [8,8 52x52]
PaintableWithLines (BlockContainer<DIV>#c) [740,8 52x52]

23
Tests/LibWeb/Layout/input/block-and-inline/float-logical.html Normal file
View file

@ -0,0 +1,23 @@
<!DOCTYPE html>
<html>
<head>
<style>
#b {
border: 1px solid red;
width: 50px;
height: 50px;
float: inline-start;
}
#c {
border: 1px solid blue;
width: 50px;
height: 50px;
float: inline-end;
}
</style>
</head>
<body>
<div id=b></div>
<div id=c></div>
</body>
</html>

4
Userland/Libraries/LibWeb/CSS/Enums.json
View file

@ -195,7 +195,9 @@
"float": [
"none",
"left",
"right"
"right",
"inline-start",
"inline-end"
],
"font-variant": [
"normal",

2
Userland/Libraries/LibWeb/CSS/Identifiers.json
View file

@ -188,8 +188,10 @@
"initial-only",
"inline",
"inline-block",
"inline-end",
"inline-flex",
"inline-grid",
"inline-start",
"inline-table",
"inset",
"inside",

13
Userland/Libraries/LibWeb/CSS/StyleComputer.cpp
View file

@ -711,6 +711,19 @@ void StyleComputer::for_each_property_expanding_shorthands(PropertyID property_i
return;
}
if (property_id == CSS::PropertyID::Float) {
auto ident = value.to_identifier();
// FIXME: Honor writing-mode, direction and text-orientation.
if (ident == CSS::ValueID::InlineStart) {
set_longhand_property(CSS::PropertyID::Float, IdentifierStyleValue::create(CSS::ValueID::Left));
return;
} else if (ident == CSS::ValueID::InlineEnd) {
set_longhand_property(CSS::PropertyID::Float, IdentifierStyleValue::create(CSS::ValueID::Right));
return;
}
}
if (property_is_shorthand(property_id)) {
// ShorthandStyleValue was handled already.
// That means if we got here, that `value` must be a CSS-wide keyword, which we should apply to our longhand properties.