0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-04 13:30:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Remove unused SessionHistoryEntry::serialized_state

Browse source 
We never implemented this for History::pushState/popState, and now that
we're working on the Navigable changes, we don't need this legacy entry
with its legacy name.
This commit is contained in:
Andrew Kaster 2023-08-22 23:31:11 -06:00 committed by Andrew Kaster
parent ca233b5cf4
commit d3a8ee6e4b
Notes: sideshowbarker 2024-07-16 22:18:54 +09:00 
Author: https://github.com/ADKaster
Commit: https://github.com/SerenityOS/serenity/commit/d3a8ee6e4b
Pull-request: https://github.com/SerenityOS/serenity/pull/20720
Reviewed-by: https://github.com/kalenikaliaksandr
Reviewed-by: https://github.com/shannonbooth ✅
2 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/BrowsingContext.cpp
View file

@ -242,7 +242,6 @@ JS::NonnullGCPtr<BrowsingContext> BrowsingContext::create_a_new_browsing_context
auto new_entry = browsing_context->heap().allocate_without_realm<SessionHistoryEntry>();
new_entry->url = AK::URL("about:blank");
new_entry->document = document.ptr();
new_entry->serialized_state = {};
new_entry->policy_container = {};
new_entry->scroll_restoration_mode = {};
new_entry->browsing_context_name = {};
@ -1244,7 +1243,6 @@ WebIDL::ExceptionOr<void> BrowsingContext::navigate_to_a_fragment(AK::URL const&
auto new_entry = heap().allocate_without_realm<SessionHistoryEntry>();
new_entry->url = url;
new_entry->document = current_entry().document;
new_entry->serialized_state = {};
new_entry->policy_container = current_entry().policy_container;
new_entry->scroll_restoration_mode = current_entry().scroll_restoration_mode;
new_entry->browsing_context_name = {};

4
Userland/Libraries/LibWeb/HTML/SessionHistoryEntry.h
View file

@ -50,10 +50,6 @@ struct SessionHistoryEntry final : public JS::Cell {
// https://html.spec.whatwg.org/multipage/browsing-the-web.html#she-document-state
JS::GCPtr<HTML::DocumentState> document_state;
// https://html.spec.whatwg.org/multipage/browsing-the-web.html#she-serialized-state
// serialized state, which is serialized state, initially StructuredSerializeForStorage(null).
Optional<DeprecatedString> serialized_state;
// https://html.spec.whatwg.org/multipage/browsing-the-web.html#she-scroll-restoration-mode
// scroll restoration mode, a scroll restoration mode, initially "auto"
ScrollRestorationMode scroll_restoration_mode { ScrollRestorationMode::Auto };