Prechádzať zdrojové kódy

LibGUI: Fix crash when clicking on small Scrollbar gutter

When a Scrollbar becomes too small to display a scrubber, clicking on
the empty gutter failed the VERIFY. This fixes that oversight.
FrHun 3 rokov pred
rodič
commit
d1d5602132
1 zmenil súbory, kde vykonal 1 pridanie a 2 odobranie
  1. 1 2
      Userland/Libraries/LibGUI/Scrollbar.cpp

+ 1 - 2
Userland/Libraries/LibGUI/Scrollbar.cpp

@@ -206,8 +206,7 @@ void Scrollbar::paint_event(PaintEvent& event)
         hovered_component_for_painting = Component::None;
         hovered_component_for_painting = Component::None;
 
 
     painter.fill_rect_with_dither_pattern(rect(), palette().button().lightened(1.3f), palette().button());
     painter.fill_rect_with_dither_pattern(rect(), palette().button().lightened(1.3f), palette().button());
-    if (m_gutter_click_state != GutterClickState::NotPressed && has_scrubber() && hovered_component_for_painting == Component::Gutter) {
-        VERIFY(!scrubber_rect().is_null());
+    if (m_gutter_click_state != GutterClickState::NotPressed && has_scrubber() && !scrubber_rect().is_null() && hovered_component_for_painting == Component::Gutter) {
         Gfx::IntRect rect_to_fill = rect();
         Gfx::IntRect rect_to_fill = rect();
         if (orientation() == Orientation::Vertical) {
         if (orientation() == Orientation::Vertical) {
             if (m_gutter_click_state == GutterClickState::BeforeScrubber) {
             if (m_gutter_click_state == GutterClickState::BeforeScrubber) {