LibWeb: Don't crash when querying offsets of empty inline elements

Previously, querying `offsetTop` or `offsetLeft` of an inline element with no text would cause a crash.
Author: https://github.com/tcl3 Commit: https://github.com/SerenityOS/serenity/commit/d1226f0b15 Pull-request: https://github.com/SerenityOS/serenity/pull/22976 Reviewed-by: https://github.com/kalenikaliaksandr
2024-01-28 20:07:48 +00:00 · 2024-01-28 20:07:48 +00:00 · d1226f0b15 · 2024-07-17 01:00:06 +09:00
commit d1226f0b15
parent 99fbd33d7d
3 changed files with 15 additions and 1 deletions
--- a/Tests/LibWeb/Text/expected/DOM/Offset-of-empty-inline-element.txt
+++ b/Tests/LibWeb/Text/expected/DOM/Offset-of-empty-inline-element.txt
@ -0,0 +1,2 @@
+  Top: 0
+Left: 0
--- a/Tests/LibWeb/Text/input/DOM/Offset-of-empty-inline-element.html
+++ b/Tests/LibWeb/Text/input/DOM/Offset-of-empty-inline-element.html
@ -0,0 +1,12 @@
+<!DOCTYPE html>
+<script src="../include.js"></script>
+<script>
+    test(() => {
+        const element = document.getElementById("empty");
+        println("Top: " + element.offsetTop);
+        println("Left: " + element.offsetLeft);
+    });
+</script>
+<body>
+    <span id="empty"></span>
+</body>
--- a/Userland/Libraries/LibWeb/Painting/Paintable.cpp
+++ b/Userland/Libraries/LibWeb/Painting/Paintable.cpp
@ -158,7 +158,7 @@ CSSPixelPoint Paintable::box_type_agnostic_position() const
        auto const& inline_paintable = static_cast<Painting::InlinePaintable const&>(*this);
        if (!inline_paintable.fragments().is_empty())
            return inline_paintable.fragments().first().absolute_rect().location();
-        VERIFY_NOT_REACHED();
+        return inline_paintable.bounding_rect().location();
    }

    CSSPixelPoint position;