소스 검색

LibGUI: Reset GlyphMapWidget only if clicking a new active glyph

Fixes an edge case in which mousing down on the active glyph within
a larger selection would reset the selection but fail to update the
glyph map. Now we can grow or shrink the selection by dragging the
active glyph even after an initial selection is made.
thankyouverycool 3 년 전
부모
커밋
cf13cf7225
1개의 변경된 파일1개의 추가작업 그리고 5개의 파일을 삭제
  1. 1 5
      Userland/Libraries/LibGUI/GlyphMapWidget.cpp

+ 1 - 5
Userland/Libraries/LibGUI/GlyphMapWidget.cpp

@@ -167,12 +167,8 @@ void GlyphMapWidget::mousedown_event(MouseEvent& event)
         auto glyph = maybe_glyph.value();
         if (event.shift())
             m_selection.extend_to(glyph);
-        else {
-            m_selection.set_size(1);
-            m_selection.set_start(glyph);
-        }
         m_in_drag_select = true;
-        set_active_glyph(glyph, ShouldResetSelection::No);
+        set_active_glyph(glyph, event.shift() ? ShouldResetSelection::No : ShouldResetSelection::Yes);
     }
 }