Pārlūkot izejas kodu

Tests: Add a unit test to ensure the /dev/mem device works correctly

To ensure everything works as expected, a unit test was added with
multiple scenarios.
This binary has to have the SetUID flag, and we also bind-mount the
/usr/Tests directory to allow running of SetUID binaries.
Liav A 3 gadi atpakaļ
vecāks
revīzija
cf0dbc9069

+ 1 - 0
Base/etc/fstab

@@ -8,5 +8,6 @@
 /root	/root	bind	bind,nodev,nosuid
 /root	/root	bind	bind,nodev,nosuid
 /var	/var	bind	bind,nodev,nosuid
 /var	/var	bind	bind,nodev,nosuid
 /www	/www	bind	bind,nodev,nosuid
 /www	/www	bind	bind,nodev,nosuid
+/usr/Tests	/usr/Tests	bind	bind,nodev
 
 
 none	/tmp	tmp	nodev,nosuid
 none	/tmp	tmp	nodev,nosuid

+ 4 - 0
Meta/build-root-filesystem.sh

@@ -102,6 +102,10 @@ if [ -f mnt/bin/utmpupdate ]; then
     chown 0:$utmp_gid mnt/bin/utmpupdate
     chown 0:$utmp_gid mnt/bin/utmpupdate
     chmod 2755 mnt/bin/utmpupdate
     chmod 2755 mnt/bin/utmpupdate
 fi
 fi
+if [ -f mnt/usr/Tests/Kernel/TestMemoryDeviceMmap ]; then
+    chown 0:0 mnt/usr/Tests/Kernel/TestMemoryDeviceMmap
+    chmod 4755 mnt/usr/Tests/Kernel/TestMemoryDeviceMmap
+fi
 
 
 chmod 0400 mnt/res/kernel.map
 chmod 0400 mnt/res/kernel.map
 chmod 0400 mnt/boot/Kernel
 chmod 0400 mnt/boot/Kernel

+ 1 - 0
Tests/Kernel/CMakeLists.txt

@@ -37,6 +37,7 @@ set(LIBTEST_BASED_SOURCES
     TestKernelFilePermissions.cpp
     TestKernelFilePermissions.cpp
     TestKernelPledge.cpp
     TestKernelPledge.cpp
     TestKernelUnveil.cpp
     TestKernelUnveil.cpp
+    TestMemoryDeviceMmap.cpp
     TestMunMap.cpp
     TestMunMap.cpp
     TestProcFS.cpp
     TestProcFS.cpp
 )
 )

+ 51 - 0
Tests/Kernel/TestMemoryDeviceMmap.cpp

@@ -0,0 +1,51 @@
+/*
+ * Copyright (c) 2021, Liav A. <liavalb@hotmail.co.il>
+ *
+ * SPDX-License-Identifier: BSD-2-Clause
+ */
+
+#include <AK/Types.h>
+#include <LibTest/TestCase.h>
+#include <assert.h>
+#include <errno.h>
+#include <fcntl.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <sys/mman.h>
+#include <unistd.h>
+
+static ALWAYS_INLINE bool mem_chunk(int fd, u64 base, u64 length)
+{
+    u64 mmoffset = base % sysconf(_SC_PAGESIZE);
+    void* mmp = mmap(NULL, mmoffset + length, PROT_READ, MAP_SHARED, fd, base - mmoffset);
+    return mmp != MAP_FAILED;
+}
+
+TEST_CASE(test_memory_access_device_mmap)
+{
+    int rc = geteuid();
+    EXPECT_EQ(rc, 0);
+
+    int fd = open("/dev/mem", O_RDONLY);
+    EXPECT_EQ(fd < 0, false);
+
+    // FIXME: This is expected to work on QEMU machines (both 440FX and Q35),
+    // however, it will be much nicer to have some sort of a node in the ProcFS
+    // to expose physical memory ranges (e820 memory map).
+
+    auto result = mem_chunk(fd, 0xe0000, 0x100000 - 0xe0000);
+    EXPECT_EQ(result, true);
+
+    result = mem_chunk(fd, 0x100000, 0x200000 - 0x100000);
+    EXPECT_EQ(result, false);
+
+    result = mem_chunk(fd, 0xf0000, 70000);
+    EXPECT_EQ(result, false);
+
+    result = mem_chunk(fd, 0xfffc0000, 16384);
+    EXPECT_EQ(result, true);
+
+    result = mem_chunk(fd, 0xfffc0000, 0x100000);
+    EXPECT_EQ(result, false);
+}