LibWeb: Allow direct rouding of CSSPixelRects to CSSPixelRects

Preciously we were casting to float, round and cast back, which actually might loose precision and was quite ugly.
Author: https://github.com/Hendiadyoin1 Commit: https://github.com/SerenityOS/serenity/commit/ce188c9a9c Pull-request: https://github.com/SerenityOS/serenity/pull/20427 Reviewed-by: https://github.com/MacDue Reviewed-by: https://github.com/kalenikaliaksandr ✅
2023-08-08 15:59:54 +02:00 · 2023-08-08 15:59:54 +02:00 · ce188c9a9c · 2024-07-17 01:55:29 +09:00
commit ce188c9a9c
parent 17b4109ba9
2 changed files with 14 additions and 2 deletions
--- a/Userland/Libraries/LibWeb/Painting/MarkerPaintable.cpp
+++ b/Userland/Libraries/LibWeb/Painting/MarkerPaintable.cpp
@ -36,8 +36,7 @@ void MarkerPaintable::paint(PaintContext& context, PaintPhase phase) const
    if (phase != PaintPhase::Foreground)
        return;

-    // FIXME: All this does is round to the nearest whole CSS pixel, but it's goofy.
-    CSSPixelRect enclosing = absolute_rect().to_type<float>().to_rounded<float>().to_type<CSSPixels>();
+    CSSPixelRect enclosing = absolute_rect().to_rounded<CSSPixels>();
    auto device_enclosing = context.enclosing_device_rect(enclosing);

    CSSPixels marker_width = enclosing.height() / 2.0;
--- a/Userland/Libraries/LibWeb/PixelUnits.h
+++ b/Userland/Libraries/LibWeb/PixelUnits.h
@ -13,6 +13,7 @@
 #include <AK/Math.h>
 #include <AK/Traits.h>
 #include <LibGfx/Forward.h>
+#include <LibGfx/Rect.h>
 #include <math.h>

 namespace Web {
@ -279,6 +280,18 @@ constexpr Web::DevicePixels abs(Web::DevicePixels const& value)
    return AK::abs(value.value());
 }

+template<>
+template<>
+[[nodiscard]] ALWAYS_INLINE Web::CSSPixelRect Web::CSSPixelRect::to_rounded<Web::CSSPixels>() const
+{
+    return {
+        round(x()),
+        round(y()),
+        round(width()),
+        round(height()),
+    };
+}
+
 namespace AK {

 template<>