0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-04 05:20:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Treat grid items with z-index != auto as positioned elements

Browse source
This commit is contained in:
Aliaksandr Kalenik 2023-08-21 17:07:53 +02:00 committed by Andreas Kling
parent 95a8dec373
commit cca779e7f6
Notes: sideshowbarker 2024-07-17 08:27:05 +09:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/SerenityOS/serenity/commit/cca779e7f6
Pull-request: https://github.com/SerenityOS/serenity/pull/20688
Reviewed-by: https://github.com/awesomekling
5 changed files with 33 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Tests/LibWeb/Ref/item-with-negative-z-index-ref.html Normal file
View file

@ -0,0 +1,8 @@
<!doctype html><style type="text/css">
* { outline: 1px solid black; }
body { display: grid; }
.foo {
grid-area: 1 / 1 / auto / auto;
background: pink;
}
</style><body><div class="foo">foo</div>

13
Tests/LibWeb/Ref/item-with-negative-z-index.html Normal file
View file

@ -0,0 +1,13 @@
<!doctype html><style type="text/css">
* { outline: 1px solid black; }
body { display: grid; }
.foo {
grid-area: 1 / 1 / auto / auto;
background: pink;
}
.bar {
grid-area: 1 / 1 / auto / auto;
background: orange;
z-index: -1;
}
</style><body><div class="foo">foo</div><div class="bar">bar</div>

1
Tests/LibWeb/Ref/manifest.json
View file

@ -1,4 +1,5 @@
{
"item-with-negative-z-index.html": "item-with-negative-z-index-ref.html",
"img-srcset-viewport-relative-sizes.html": "img-srcset-viewport-relative-sizes-ref.html",
"grid-items-painting-order.html": "grid-items-painting-order-ref.html",
"square-flex.html": "square-ref.html",

10
Userland/Libraries/LibWeb/Painting/Paintable.cpp
View file

@ -27,6 +27,16 @@ void Paintable::visit_edges(Cell::Visitor& visitor)
visitor.visit(m_containing_block.value());
}
bool Paintable::is_positioned() const
{
if (layout_node().is_grid_item() && computed_values().z_index().has_value()) {
// https://www.w3.org/TR/css-grid-2/#z-order
// grid items with z_index should behave as if position were "relative"
return true;
}
return computed_values().position() != CSS::Position::Static;
}
void Paintable::set_dom_node(JS::GCPtr<DOM::Node> dom_node)
{
m_dom_node = dom_node;

2
Userland/Libraries/LibWeb/Painting/Paintable.h
View file

@ -56,7 +56,7 @@ class Paintable
public:
virtual ~Paintable() = default;
[[nodiscard]] bool is_positioned() const { return layout_node().is_positioned(); }
[[nodiscard]] bool is_positioned() const;
[[nodiscard]] bool is_fixed_position() const { return layout_node().is_fixed_position(); }
[[nodiscard]] bool is_absolutely_positioned() const { return layout_node().is_absolutely_positioned(); }
[[nodiscard]] bool is_floating() const { return layout_node().is_floating(); }