0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Kernel/Devices: Remove SerialDevice::initialize method

Browse source 
We can just do the initialization sequence in the constructor.
This commit is contained in:
Liav A. 2024-03-01 12:27:41 +02:00 • committed by Andrew Kaster
parent b4c218168f
commit cb558f4459
Notes: sideshowbarker 2024-07-17 03:03:44 +09:00
1 changed files with 5 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
Kernel/Devices/SerialDevice.cpp
View file

@ -16,7 +16,11 @@ SerialDevice::SerialDevice(NonnullOwnPtr<IOWindow> registers_io_window, unsigned
: CharacterDevice(4, minor)
, m_registers_io_window(move(registers_io_window))
{
initialize();
set_interrupts(false);
set_baud(Baud38400);
set_line_control(None, One, EightBits);
set_fifo_control(EnableFIFO | ClearReceiveFIFO | ClearTransmitFIFO | TriggerLevel4);
set_modem_control(RequestToSend | DataTerminalReady);
}
SerialDevice::~SerialDevice() = default;
@ -76,15 +80,6 @@ void SerialDevice::put_char(char ch)
m_last_put_char_was_carriage_return = (ch == '\r');
}
void SerialDevice::initialize()
{
set_interrupts(false);
set_baud(Baud38400);
set_line_control(None, One, EightBits);
set_fifo_control(EnableFIFO | ClearReceiveFIFO | ClearTransmitFIFO | TriggerLevel4);
set_modem_control(RequestToSend | DataTerminalReady);
}
void SerialDevice::set_interrupts(bool interrupt_enable)
{
m_interrupt_enable = interrupt_enable;