From cb151321463b133fbdfff57c0ab25da067e66410 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Mon, 5 Sep 2022 12:21:48 +0200 Subject: [PATCH] LibWeb: Always allow scripting in workers for now Workers don't have a document, so we can't ask them if scripting is enabled or not. This is not the right long-term fix, but it fixes an assertion when trying to query the missing responsible document of a web worker. --- Userland/Libraries/LibWeb/HTML/Scripting/Environments.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Userland/Libraries/LibWeb/HTML/Scripting/Environments.cpp b/Userland/Libraries/LibWeb/HTML/Scripting/Environments.cpp index eea9c37b953..3d34ee10df9 100644 --- a/Userland/Libraries/LibWeb/HTML/Scripting/Environments.cpp +++ b/Userland/Libraries/LibWeb/HTML/Scripting/Environments.cpp @@ -244,6 +244,10 @@ bool EnvironmentSettingsObject::is_scripting_enabled() const // The user agent supports scripting. // NOTE: This is always true in LibWeb :^) + // FIXME: Do the right thing for workers. + if (!is(m_realm_execution_context->realm->global_object())) + return true; + // The user has not disabled scripting for settings at this time. (User agents may provide users with the option to disable scripting globally, or in a finer-grained manner, e.g., on a per-origin basis, down to the level of individual environment settings objects.) auto document = const_cast(*this).responsible_document(); VERIFY(document);