0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibWeb: Inherit TableFormattingContext from FC instead of BFC

Browse source
This commit is contained in:
Aliaksandr Kalenik 2022-12-04 21:57:21 +03:00 • committed by Andreas Kling
parent fae0b96fe4
commit ca123350cc
Notes: sideshowbarker 2024-07-17 08:35:21 +09:00
2 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibWeb/Layout/TableFormattingContext.cpp
View file

@ -36,8 +36,8 @@ struct Traits<GridPosition> : public GenericTraits<GridPosition> {
namespace Web::Layout {
TableFormattingContext::TableFormattingContext(LayoutState& state, BlockContainer const& block_container, FormattingContext* parent)
: BlockFormattingContext(state, block_container, parent)
TableFormattingContext::TableFormattingContext(LayoutState& state, BlockContainer const& root, FormattingContext* parent)
: FormattingContext(Type::Table, state, root, parent)
{
}
@ -246,10 +246,10 @@ void TableFormattingContext::run(Box const& box, LayoutMode, AvailableSpace cons
cell_state.border_right = cell.box.computed_values().border_right().width;
cell_state.set_content_width(span_width - cell_state.border_box_left() - cell_state.border_box_right());
if (auto independent_formatting_context = layout_inside(cell.box, LayoutMode::Normal, cell_state.available_inner_space_or_constraints_from(available_space)))
independent_formatting_context->parent_context_did_dimension_child_root_box();
BlockFormattingContext::compute_height(cell.box, AvailableSpace(AvailableSize::make_indefinite(), AvailableSize::make_indefinite()));
auto independent_formatting_context = layout_inside(cell.box, LayoutMode::Normal, cell_state.available_inner_space_or_constraints_from(available_space));
VERIFY(independent_formatting_context);
cell_state.set_content_height(independent_formatting_context->automatic_content_height());
independent_formatting_context->parent_context_did_dimension_child_root_box();
cell.baseline = box_baseline(m_state, cell.box);

4
Userland/Libraries/LibWeb/Layout/TableFormattingContext.h
View file

@ -7,11 +7,11 @@
#pragma once
#include <AK/Forward.h>
#include <LibWeb/Layout/BlockFormattingContext.h>
#include <LibWeb/Layout/FormattingContext.h>
namespace Web::Layout {
class TableFormattingContext final : public BlockFormattingContext {
class TableFormattingContext final : public FormattingContext {
public:
explicit TableFormattingContext(LayoutState&, BlockContainer const&, FormattingContext* parent);
~TableFormattingContext();