We use cookies to ensure you get the best experience on our website
Inicio Explorar Axuda
Rexistro Iniciar sesión
0ct0pu5
/
ladybird
1
0
Fork 0
Ficheiros Incidencias 0 Pull Requests 0 Wiki
Explorar o código

LibWeb: Clean previous border radii clips in refresh_clip_state()

The list of border radii clips needs to be reset before being populated
with new clips that have refreshed positions. Besides fixing painting,
this also improves performance because the number of sample/blit
commands does not increase as we scroll.
Aliaksandr Kalenik hai 1 ano
pai
91378ded96
achega
c74fc4c171
Modificáronse 4 ficheiros con 67 adicións e 0 borrados
Dividir vista Mostrar estatísticas de Diff
  1. 38 0
      Tests/LibWeb/Ref/corner-clip-inside-scrollable.html
  2. 27 0
      Tests/LibWeb/Ref/reference/corner-clip-inside-scrollable-ref.html
  3. 1 0
      Userland/Libraries/LibWeb/Painting/ClipFrame.h
  4. 1 0
      Userland/Libraries/LibWeb/Painting/ViewportPaintable.cpp

+ 38 - 0
Tests/LibWeb/Ref/corner-clip-inside-scrollable.html
Ver ficheiro 

@@ -0,0 +1,38 @@
 
+<!DOCTYPE html>
 
+<link rel="match" href="reference/corner-clip-inside-scrollable-ref.html" />
 
+<style>
 
+    * {
 
+        scrollbar-width: none;
 
+    }
 
+
 
+    .box {
 
+        width: 100px;
 
+        height: 100px;
 
+        border: 5px solid black;
 
+        border-radius: 50%;
 
+        overflow: hidden;
 
+        box-sizing: border-box;
 
+    }
 
+
 
+    .inner-box {
 
+        width: 100px;
 
+        height: 100px;
 
+        background-color: magenta;
 
+    }
 
+
 
+    #scroll {
 
+        overflow: scroll;
 
+        width: 200px;
 
+        height: 200px;
 
+        border: 1px solid black;
 
+    }
 
+</style>
 
+<div id="scroll">
 
+    <div class="box" id="a"><div class="inner-box" id="aa"></div></div>
 
+    <div class="box" id="b"><div class="inner-box" id="bb"></div></div>
 
+    <div class="box" id="c"><div class="inner-box" id="cc"></div></div>
 
+</div>
 
+<script>
 
+    const scroll = document.getElementById("scroll");
 
+    scroll.scrollTop = 100;
 
+</script>

+ 27 - 0
Tests/LibWeb/Ref/reference/corner-clip-inside-scrollable-ref.html
Ver ficheiro 

@@ -0,0 +1,27 @@
 
+<!DOCTYPE html>
 
+<style>
 
+    .box {
 
+        width: 100px;
 
+        height: 100px;
 
+        border: 5px solid black;
 
+        border-radius: 50%;
 
+        overflow: hidden;
 
+        box-sizing: border-box;
 
+    }
 
+
 
+    .inner-box {
 
+        width: 100px;
 
+        height: 100px;
 
+        background-color: magenta;
 
+    }
 
+
 
+    #container {
 
+        width: 200px;
 
+        height: 200px;
 
+        border: 1px solid black;
 
+    }
 
+</style>
 
+<div id="container">
 
+    <div class="box" id="a"><div class="inner-box" id="aa"></div></div>
 
+    <div class="box" id="b"><div class="inner-box" id="bb"></div></div>
 
+</div>

+ 1 - 0
Userland/Libraries/LibWeb/Painting/ClipFrame.h
Ver ficheiro 

@@ -28,6 +28,7 @@ struct ClipFrame : public RefCounted<ClipFrame> {
 
         }
 
         m_border_radii_clips.append(border_radii_clip);
 
     }
 
+    void clear_border_radii_clips() { m_border_radii_clips.clear(); }
 
 
     CSSPixelRect rect() const { return m_rect; }
 
     void set_rect(CSSPixelRect rect) { m_rect = rect; }

+ 1 - 0
Userland/Libraries/LibWeb/Painting/ViewportPaintable.cpp
Ver ficheiro 

@@ -143,6 +143,7 @@ void ViewportPaintable::refresh_clip_state()
 
         // Start from CSS clip property if it exists.
 
         Optional<CSSPixelRect> clip_rect = paintable_box.get_clip_rect();
 
 
+        clip_frame.clear_border_radii_clips();
 
         if (overflow_x != CSS::Overflow::Visible && overflow_y != CSS::Overflow::Visible) {
 
             auto overflow_clip_rect = paintable_box.compute_absolute_padding_rect_with_css_transform_applied();
 
             for (auto const* block = &paintable_box.layout_box(); !block->is_viewport(); block = block->containing_block()) {

Contact | Legal | Takedown | Status
Self-hosted public services - About
NibbleSpot by 0ct0pu5