0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibWeb: Add window.internals.getComputedRole(element)

Browse source 
This change adds a window.internals.getComputedLabel(element) function,
for use in testing ARIA-related behavior. It also patches the imported
WPT testdriver.js script’s test_driver.get_computed_role(element)
function to call our window.internals.getComputedRole(element) function.
This commit is contained in:
sideshowbarker 2024-12-06 16:29:11 +09:00 • committed by Tim Ledbetter
parent d946d94e2d
commit c5966bbdcb
Notes: github-actions[bot] 2024-12-06 18:32:55 +00:00
4 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibWeb/Internals/Internals.cpp
View file

@ -203,6 +203,14 @@ void Internals::expire_cookies_with_time_offset(WebIDL::LongLong seconds)
internals_page().client().page_did_expire_cookies_with_time_offset(AK::Duration::from_seconds(seconds));
}
// NOLINTNEXTLINE(readability-convert-member-functions-to-static
String Internals::get_computed_role(DOM::Element& element)
{
if (auto role = element.role_or_default(); role.has_value())
return MUST(String::from_utf8(ARIA::role_name(role.value())));
return String {};
}
String Internals::get_computed_label(DOM::Element& element)
{
auto& active_document = internals_window().associated_document();

1
Libraries/LibWeb/Internals/Internals.h
View file

@ -48,6 +48,7 @@ public:
void enable_cookies_on_file_domains();
void expire_cookies_with_time_offset(WebIDL::LongLong seconds);
String get_computed_role(DOM::Element& element);
String get_computed_label(DOM::Element& element);
static u16 get_echo_server_port();

1
Libraries/LibWeb/Internals/Internals.idl
View file

@ -38,6 +38,7 @@ interface Internals {
undefined enableCookiesOnFileDomains();
undefined expireCookiesWithTimeOffset(long long seconds);
DOMString getComputedRole(Element element);
DOMString getComputedLabel(Element element);
unsigned short getEchoServerPort();
};

6
Tests/LibWeb/Text/input/wpt-import/resources/testdriver.js
View file

@ -250,7 +250,11 @@
* rejected in the cases the WebDriver command errors
*/
get_computed_role: async function(element) {
let role = await window.test_driver_internal.get_computed_role(element);
// XXX: Ladybird-specific change: Upstream WPT calls
// window.test_driver_internal.get_computed_role(element) here,
// but we’ve changed that to our Ladybird-specific
// window.internals.getComputedRole(el).
let role = await window.internals.getComputedRole(element);
return role;
},