This was preventing window realms from ever being garbage collected.
@@ -12,7 +12,7 @@ namespace Web::HTML {
WindowEnvironmentSettingsObject::WindowEnvironmentSettingsObject(Window& window, NonnullOwnPtr<JS::ExecutionContext> execution_context)
: EnvironmentSettingsObject(move(execution_context))
- , m_window(JS::make_handle(window))
+ , m_window(window)
{
}
@@ -26,7 +26,7 @@ public:
private:
WindowEnvironmentSettingsObject(Window&, NonnullOwnPtr<JS::ExecutionContext>);
- JS::Handle<Window> m_window;
+ WeakPtr<Window> m_window;
};