LibCrypto: Cleanup UnsignedBigInteger a bit

- Add missing 'explicit' to the constructor - Remove unneeded 'AK::' in AK::Vector - Avoid copying 'words' in constructor
Author: https://github.com/itamar8910 Commit: https://github.com/SerenityOS/serenity/commit/c52d3e65b90 Pull-request: https://github.com/SerenityOS/serenity/pull/1661 Reviewed-by: https://github.com/Dexesttp Reviewed-by: https://github.com/alimpfard Reviewed-by: https://github.com/awesomekling
2020-04-09 18:59:53 +03:00 · 2020-04-09 18:59:53 +03:00 · c52d3e65b9 · 2024-07-19 07:05:30 +09:00
commit c52d3e65b9
parent 2125a4debb
1 changed files with 3 additions and 3 deletions
--- a/Libraries/LibCrypto/BigInt/UnsignedBigInteger.h
+++ b/Libraries/LibCrypto/BigInt/UnsignedBigInteger.h
@ -38,12 +38,12 @@ class UnsignedBigInteger {
 public:
    UnsignedBigInteger(u32 x) { m_words.append(x); }

-    UnsignedBigInteger(AK::Vector<u32>&& words)
-        : m_words(words)
+    explicit UnsignedBigInteger(AK::Vector<u32, STARTING_WORD_SIZE>&& words)
+        : m_words(move(words))
    {
    }

-    UnsignedBigInteger() {}
+    UnsignedBigInteger() { }

    static UnsignedBigInteger from_base10(const String& str);
    static UnsignedBigInteger create_invalid();