LibIDL+WrapperGenerator: Move IDL code into a library

IDL function overload resolution requires knowing each IDL function's
parameters and their types at runtime. The simplest way to do that is
just to make the types the generator uses available to the runtime.

Parsing has moved to LibIDL, but code generation has not, since that is
very specific to WrapperGenerator.

Meta/Lagom/CMakeLists.txt

@@ -291,6 +291,13 @@ lagom_lib(TimeZone timezone
 )
 target_compile_definitions(LibTimeZone PRIVATE ENABLE_TIME_ZONE_DATA=$<BOOL:${ENABLE_TIME_ZONE_DATABASE_DOWNLOAD}>)
 
+# LibIDL
+# This is used by the WrapperGenerator so needs to always be built.
+file(GLOB LIBIDL_SOURCES CONFIGURE_DEPENDS "../../Userland/Libraries/LibIDL/*.cpp")
+lagom_lib(IDL idl
+    SOURCES ${LIBIDL_SOURCES}
+)
+
 # Manually install AK headers
 install(
     DIRECTORY "${SERENITY_PROJECT_ROOT}/AK"
@@ -548,7 +555,7 @@ if (BUILD_LAGOM)
 
         lagom_lib(Web web
             SOURCES ${LIBWEB_SOURCES} ${LIBWEB_SUBDIR_SOURCES} ${LIBWEB_SUBSUBDIR_SOURCES} ${LIBWEB_SUBSUBSUBDIR_SOURCES} ${LIBWEB_GENERATED_SOURCES}
-            LIBS LibMarkdown LibGemini LibGfx LibGL LibJS LibTextCodec LibWasm LibXML
+            LIBS LibMarkdown LibGemini LibGfx LibGL LibIDL LibJS LibTextCodec LibWasm LibXML
         )
         generate_js_wrappers(LibWeb)
     endif()

Meta/Lagom/Tools/CodeGenerators/LibWeb/WrapperGenerator/CMakeLists.txt

@@ -1,8 +1,7 @@
-set(SOURCES "")
-
-lagom_tool(WrapperGenerator SOURCES
+set(SOURCES
     IDLGenerators.cpp
-    IDLParser.cpp
-    main.cpp)
+    main.cpp
+)
 
+lagom_tool(WrapperGenerator LIBS LibIDL)
 target_compile_options(WrapperGenerator PUBLIC -g)

Meta/Lagom/Tools/CodeGenerators/LibWeb/WrapperGenerator/IDLGenerators.cpp

@@ -7,10 +7,10 @@
  * SPDX-License-Identifier: BSD-2-Clause
  */
 
-#include "IDLTypes.h"
 #include <AK/LexicalPath.h>
 #include <AK/Queue.h>
 #include <AK/QuickSort.h>
+#include <LibIDL/Types.h>
 
 Vector<StringView> s_header_search_paths;
 

Meta/Lagom/Tools/CodeGenerators/LibWeb/WrapperGenerator/main.cpp

@@ -7,12 +7,12 @@
  * SPDX-License-Identifier: BSD-2-Clause
  */
 
-#include "IDLParser.h"
-#include "IDLTypes.h"
 #include <AK/Debug.h>
 #include <AK/LexicalPath.h>
 #include <LibCore/ArgsParser.h>
 #include <LibCore/File.h>
+#include <LibIDL/IDLParser.h>
+#include <LibIDL/Types.h>
 
 extern Vector<StringView> s_header_search_paths;
 

Userland/Libraries/CMakeLists.txt

@@ -26,6 +26,7 @@ add_subdirectory(LibGL)
 add_subdirectory(LibGPU)
 add_subdirectory(LibGUI)
 add_subdirectory(LibHTTP)
+add_subdirectory(LibIDL)
 add_subdirectory(LibIMAP)
 add_subdirectory(LibImageDecoderClient)
 add_subdirectory(LibIPC)

Userland/Libraries/LibIDL/CMakeLists.txt

@@ -0,0 +1,6 @@
+set(SOURCES
+    IDLParser.cpp
+)
+
+serenity_lib(LibIDL idl)
+target_link_libraries(LibIDL LibCore)

Userland/Libraries/LibIDL/IDLParser.cpp

@@ -805,7 +805,7 @@ void Parser::parse_non_interface_entities(bool allow_interface, Interface& inter
     consume_whitespace();
 }
 
-void resolve_typedef(Interface& interface, NonnullRefPtr<Type>& type, HashMap<String, String>* extended_attributes = {})
+static void resolve_typedef(Interface& interface, NonnullRefPtr<Type>& type, HashMap<String, String>* extended_attributes = {})
 {
     if (is<ParameterizedType>(*type)) {
         auto parameterized_type = static_ptr_cast<ParameterizedType>(type);
@@ -826,7 +826,7 @@ void resolve_typedef(Interface& interface, NonnullRefPtr<Type>& type, HashMap<St
     for (auto& attribute : it->value.extended_attributes)
         extended_attributes->set(attribute.key, attribute.value);
 }
-void resolve_parameters_typedefs(Interface& interface, Vector<Parameter>& parameters)
+static void resolve_parameters_typedefs(Interface& interface, Vector<Parameter>& parameters)
 {
     for (auto& parameter : parameters)
         resolve_typedef(interface, parameter.type, &parameter.extended_attributes);

Userland/Libraries/LibIDL/IDLParser.h

@@ -9,9 +9,9 @@
 
 #pragma once
 
-#include "IDLTypes.h"
 #include <AK/CharacterTypes.h>
 #include <AK/GenericLexer.h>
+#include <LibIDL/Types.h>
 
 namespace IDL {