0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibWeb: Avoid Vector filtering when performing find in page queries

Browse source
This commit is contained in:
Tim Ledbetter 2024-11-24 16:46:42 +00:00 • committed by Tim Ledbetter
parent 26f32b11f9
commit c322603c42
Notes: github-actions[bot] 2024-11-24 19:29:20 +00:00
3 changed files with 5 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/HTML/EventLoop/EventLoop.cpp
View file

@ -513,7 +513,7 @@ void EventLoop::perform_a_microtask_checkpoint()
// FIXME: 8. Record timing info for microtask checkpoint. // FIXME: 8. Record timing info for microtask checkpoint.
} }
Vector<GC::Root<DOM::Document>> EventLoop::documents_in_this_event_loop_matching(auto callback) const Vector<GC::Root<DOM::Document>> EventLoop::documents_in_this_event_loop_matching(Function<bool(DOM::Document&)> callback) const
{ {
Vector<GC::Root<DOM::Document>> documents; Vector<GC::Root<DOM::Document>> documents;
for (auto& document : m_documents) { for (auto& document : m_documents) {

3
Libraries/LibWeb/HTML/EventLoop/EventLoop.h
View file

@ -73,6 +73,7 @@ public:
void unregister_document(Badge<DOM::Document>, DOM::Document&); void unregister_document(Badge<DOM::Document>, DOM::Document&);
Vector<GC::Root<DOM::Document>> documents_in_this_event_loop() const; Vector<GC::Root<DOM::Document>> documents_in_this_event_loop() const;
[[nodiscard]] Vector<GC::Root<DOM::Document>> documents_in_this_event_loop_matching(Function<bool(DOM::Document&)> callback) const;
Vector<GC::Root<HTML::Window>> same_loop_windows() const; Vector<GC::Root<HTML::Window>> same_loop_windows() const;
@ -95,8 +96,6 @@ private:
virtual void visit_edges(Visitor&) override; virtual void visit_edges(Visitor&) override;
[[nodiscard]] Vector<GC::Root<DOM::Document>> documents_in_this_event_loop_matching(auto callback) const;
void update_the_rendering(); void update_the_rendering();
Type m_type { Type::Window }; Type m_type { Type::Window };

8
Libraries/LibWeb/Page/Page.cpp
View file

@ -569,11 +569,9 @@ Vector<GC::Root<DOM::Document>> Page::documents_in_active_window() const
if (!top_level_traversable_is_initialized()) if (!top_level_traversable_is_initialized())
return {}; return {};
auto documents = HTML::main_thread_event_loop().documents_in_this_event_loop(); auto documents = HTML::main_thread_event_loop().documents_in_this_event_loop_matching([&](auto& document) {
for (ssize_t i = documents.size() - 1; i >= 0; --i) { return document.window() == top_level_traversable()->active_window();
if (documents[i]->window() != top_level_traversable()->active_window()) });
documents.remove(i);
}
return documents; return documents;
} }