LibWeb: Avoid Vector filtering when performing find in page queries

Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/c322603c420
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2550
Reviewed-by: https://github.com/awesomekling ✅

Libraries/LibWeb/HTML/EventLoop/EventLoop.cpp

@@ -513,7 +513,7 @@ void EventLoop::perform_a_microtask_checkpoint()
     // FIXME: 8. Record timing info for microtask checkpoint.
 }
 
-Vector<GC::Root<DOM::Document>> EventLoop::documents_in_this_event_loop_matching(auto callback) const
+Vector<GC::Root<DOM::Document>> EventLoop::documents_in_this_event_loop_matching(Function<bool(DOM::Document&)> callback) const
 {
     Vector<GC::Root<DOM::Document>> documents;
     for (auto& document : m_documents) {

Libraries/LibWeb/HTML/EventLoop/EventLoop.h

@@ -73,6 +73,7 @@ public:
     void unregister_document(Badge<DOM::Document>, DOM::Document&);
 
     Vector<GC::Root<DOM::Document>> documents_in_this_event_loop() const;
+    [[nodiscard]] Vector<GC::Root<DOM::Document>> documents_in_this_event_loop_matching(Function<bool(DOM::Document&)> callback) const;
 
     Vector<GC::Root<HTML::Window>> same_loop_windows() const;
 
@@ -95,8 +96,6 @@ private:
 
     virtual void visit_edges(Visitor&) override;
 
-    [[nodiscard]] Vector<GC::Root<DOM::Document>> documents_in_this_event_loop_matching(auto callback) const;
-
     void update_the_rendering();
 
     Type m_type { Type::Window };

Libraries/LibWeb/Page/Page.cpp

@@ -569,11 +569,9 @@ Vector<GC::Root<DOM::Document>> Page::documents_in_active_window() const
     if (!top_level_traversable_is_initialized())
         return {};
 
-    auto documents = HTML::main_thread_event_loop().documents_in_this_event_loop();
-    for (ssize_t i = documents.size() - 1; i >= 0; --i) {
-        if (documents[i]->window() != top_level_traversable()->active_window())
-            documents.remove(i);
-    }
+    auto documents = HTML::main_thread_event_loop().documents_in_this_event_loop_matching([&](auto& document) {
+        return document.window() == top_level_traversable()->active_window();
+    });
 
     return documents;
 }