0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibWeb: Use machine epsilon when approximating cubic bezier

Browse source
This commit is contained in:
Gingeh 2024-11-02 20:23:50 +11:00 • committed by Alexander Kalenik
parent 9395b266c6
commit c2cd191864
Notes: github-actions[bot] 2024-11-03 16:36:14 +00:00
3 changed files with 29 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/css/cubic-bezier-infinite-slope-crash.txt Normal file
View file

@ -0,0 +1 @@
PASS! (Didn't crash)

24
Tests/LibWeb/Text/input/css/cubic-bezier-infinite-slope-crash.html Normal file
View file

@ -0,0 +1,24 @@
<!DOCTYPE html>
<style>
#foo {
animation-name: anim;
animation-play-state: paused;
animation-fill-mode: forwards;
animation-timing-function: cubic-bezier(0.4, 0.1, 1, 0);
}
@keyframes anim {}
</style>
<div id="foo"></div>
<script src="../include.js"></script>
<script>
asyncTest(async (done) => {
const foo = document.getElementById("foo");
const anim = foo.getAnimations()[0];
anim.onfinish = function () {
println("PASS! (Didn't crash)");
done();
};
anim.play();
});
</script>

8
Userland/Libraries/LibWeb/CSS/StyleValues/EasingStyleValue.cpp
View file

@ -126,9 +126,9 @@ double EasingStyleValue::Function::evaluate_at(double input_progress, bool befor
size_t nearby_index = 0;
if (auto found = binary_search(cached_x_samples, x, &nearby_index, [](auto x, auto& sample) {
if (x > sample.x)
if (x - sample.x >= NumericLimits<double>::epsilon())
return 1;
if (x < sample.x)
if (x - sample.x <= NumericLimits<double>::epsilon())
return -1;
return 0;
}))
@ -146,9 +146,9 @@ double EasingStyleValue::Function::evaluate_at(double input_progress, bool befor
}
if (auto found = binary_search(cached_x_samples, x, &nearby_index, [](auto x, auto& sample) {
if (x > sample.x)
if (x - sample.x >= NumericLimits<double>::epsilon())
return 1;
if (x < sample.x)
if (x - sample.x <= NumericLimits<double>::epsilon())
return -1;
return 0;
}))