ソースを参照

LibWeb: Not dispatching page_did_click_link event breaks page refresh

The WebView url wouldn't update so reload in Tab would still use the
previous URL before any left click navigation.

I am unsure if there was any good reason not to dispatch the event when
there are no modifiers.
Rob Ryan 3 年 前
コミット
c1b311835b
1 ファイル変更1 行追加1 行削除
  1. 1 1
      Userland/Libraries/LibWeb/Page/EventHandler.cpp

+ 1 - 1
Userland/Libraries/LibWeb/Page/EventHandler.cpp

@@ -218,7 +218,7 @@ bool EventHandler::handle_mouseup(Gfx::IntPoint const& position, unsigned button
                         document->run_javascript(href.substring_view(11, href.length() - 11));
                     } else if (!url.fragment().is_null() && url.equals(document->url(), AK::URL::ExcludeFragment::Yes)) {
                         m_browsing_context.scroll_to_anchor(url.fragment());
-                    } else if (modifiers != 0) {
+                    } else {
                         if (m_browsing_context.is_top_level()) {
                             if (auto* page = m_browsing_context.page())
                                 page->client().page_did_click_link(url, link->target(), modifiers);