Sfoglia il codice sorgente

WebContent+Friends: Add get_element_tag_name IPC and plumbing

Tobias Christiansen 2 anni fa
parent
commit
be6bbdaa3b

+ 4 - 0
Userland/Applications/Browser/BrowserWindow.cpp

@@ -606,6 +606,10 @@ void BrowserWindow::create_new_tab(URL url, bool activate)
         return active_tab().view().get_computed_value_for_element(element_id, property_name);
     };
 
+    new_tab.webdriver_endpoints().on_get_element_tag_name = [this](i32 element_id) {
+        return active_tab().view().get_element_tag_name(element_id);
+    };
+
     new_tab.load(url);
 
     dbgln_if(SPAM_DEBUG, "Added new tab {:p}, loading {}", &new_tab, url);

+ 1 - 0
Userland/Applications/Browser/WebDriverEndpoints.h

@@ -23,6 +23,7 @@ public:
     Function<Optional<String>(i32 element_id, String const&)> on_get_element_property;
     Function<String()> on_get_active_documents_type;
     Function<String(i32 element_id, String const&)> on_get_computed_value_for_element;
+    Function<String(i32 element_id)> on_get_element_tag_name;
 };
 
 }

+ 5 - 0
Userland/Libraries/LibWebView/OutOfProcessWebView.cpp

@@ -545,6 +545,11 @@ String OutOfProcessWebView::get_computed_value_for_element(i32 element_id, Strin
     return client().get_computed_value_for_element(element_id, property_name);
 }
 
+String OutOfProcessWebView::get_element_tag_name(i32 element_id)
+{
+    return client().get_element_tag_name(element_id);
+}
+
 void OutOfProcessWebView::set_content_filters(Vector<String> filters)
 {
     client().async_set_content_filters(filters);

+ 1 - 0
Userland/Libraries/LibWebView/OutOfProcessWebView.h

@@ -64,6 +64,7 @@ public:
     Optional<String> get_element_property(i32 element_id, String const& name);
     String get_active_documents_type();
     String get_computed_value_for_element(i32 element_id, String const& property_name);
+    String get_element_tag_name(i32 element_id);
 
     void set_content_filters(Vector<String>);
     void set_proxy_mappings(Vector<String> proxies, HashMap<String, size_t> mappings);

+ 14 - 0
Userland/Services/WebContent/ConnectionFromClient.cpp

@@ -561,6 +561,20 @@ Messages::WebContentServer::GetComputedValueForElementResponse ConnectionFromCli
     return { style_value->to_string() };
 }
 
+Messages::WebContentServer::GetElementTagNameResponse ConnectionFromClient::get_element_tag_name(i32 element_id)
+{
+    auto* node = Web::DOM::Node::from_id(element_id);
+    if (!node)
+        return { "" };
+
+    if (!node->is_element())
+        return { "" };
+
+    auto& element = verify_cast<Web::DOM::Element>(*node);
+
+    return { element.tag_name() };
+}
+
 Messages::WebContentServer::GetSelectedTextResponse ConnectionFromClient::get_selected_text()
 {
     return page().focused_context().selected_text();

+ 1 - 0
Userland/Services/WebContent/ConnectionFromClient.h

@@ -85,6 +85,7 @@ private:
     virtual Messages::WebContentServer::GetElementPropertyResponse get_element_property(i32 element_id, String const& name) override;
     virtual Messages::WebContentServer::GetActiveDocumentsTypeResponse get_active_documents_type() override;
     virtual Messages::WebContentServer::GetComputedValueForElementResponse get_computed_value_for_element(i32 element_id, String const& property_name) override;
+    virtual Messages::WebContentServer::GetElementTagNameResponse get_element_tag_name(i32 element_id) override;
 
     virtual Messages::WebContentServer::GetLocalStorageEntriesResponse get_local_storage_entries() override;
     virtual Messages::WebContentServer::GetSessionStorageEntriesResponse get_session_storage_entries() override;

+ 1 - 0
Userland/Services/WebContent/WebContentServer.ipc

@@ -43,6 +43,7 @@ endpoint WebContentServer
     get_element_property(i32 element_id, String name) => (Optional<String> property)
     get_active_documents_type() => (String type)
     get_computed_value_for_element(i32 element_id, String property_name) => (String computed_value)
+    get_element_tag_name(i32 element_id) => (String tag_name)
 
     run_javascript(String js_source) =|