From ba390f9b34e99add35a6a1d349f97f86f583daf0 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Fri, 22 May 2020 13:37:57 +0200 Subject: [PATCH] Kernel: Remove outdated FIXME's in the static ACPI parser We no longer blindly use PAGE_SIZE here. :^) --- Kernel/ACPI/Parser.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Kernel/ACPI/Parser.cpp b/Kernel/ACPI/Parser.cpp index dae7504f5c1..47b739bd303 100644 --- a/Kernel/ACPI/Parser.cpp +++ b/Kernel/ACPI/Parser.cpp @@ -345,7 +345,6 @@ Optional StaticParsing::find_rsdp() PhysicalAddress StaticParsing::find_table(PhysicalAddress rsdp_address, const StringView& signature) { // FIXME: There's no validation of ACPI tables here. Use the checksum to validate the tables. - // FIXME: Don't blindly use PAGE_SIZE here, but probe the actual length. ASSERT(signature.length() == 4); auto rsdp = map_typed(rsdp_address); @@ -364,7 +363,6 @@ PhysicalAddress StaticParsing::find_table(PhysicalAddress rsdp_address, const St static PhysicalAddress search_table_in_xsdt(PhysicalAddress xsdt_address, const StringView& signature) { // FIXME: There's no validation of ACPI tables here. Use the checksum to validate the tables. - // FIXME: Don't blindly use PAGE_SIZE here, but probe the actual length. ASSERT(signature.length() == 4); auto xsdt = map_typed(xsdt_address); @@ -379,7 +377,6 @@ static PhysicalAddress search_table_in_xsdt(PhysicalAddress xsdt_address, const static bool match_table_signature(PhysicalAddress table_header, const StringView& signature) { // FIXME: There's no validation of ACPI tables here. Use the checksum to validate the tables. - // FIXME: Don't blindly use PAGE_SIZE here, but probe the actual length. ASSERT(signature.length() == 4); auto table = map_typed(table_header); @@ -389,7 +386,6 @@ static bool match_table_signature(PhysicalAddress table_header, const StringView static PhysicalAddress search_table_in_rsdt(PhysicalAddress rsdt_address, const StringView& signature) { // FIXME: There's no validation of ACPI tables here. Use the checksum to validate the tables. - // FIXME: Don't blindly use PAGE_SIZE here, but probe the actual length. ASSERT(signature.length() == 4); auto rsdt = map_typed(rsdt_address);