浏览代码

SystemMonitor: Invalidate ProcessModel indexes when necessary

If the process table grows or shrinks, we need to invalidate all the
ProcessModel indexes. This is not great, but it's the most precise
invalidation we can do at the moment.
Andreas Kling 5 年之前
父节点
当前提交
b9ae937279
共有 1 个文件被更改,包括 4 次插入1 次删除
  1. 4 1
      Applications/SystemMonitor/ProcessModel.cpp

+ 4 - 1
Applications/SystemMonitor/ProcessModel.cpp

@@ -352,6 +352,7 @@ GUI::Variant ProcessModel::data(const GUI::ModelIndex& index, Role role) const
 
 void ProcessModel::update()
 {
+    auto previous_pid_count = m_pids.size();
     auto all_processes = Core::ProcessStatisticsReader::get_all();
 
     unsigned last_sum_times_scheduled = 0;
@@ -434,5 +435,7 @@ void ProcessModel::update()
     if (on_cpu_info_change)
         on_cpu_info_change(m_cpus);
 
-    did_update(GUI::Model::UpdateFlag::DontInvalidateIndexes);
+    // FIXME: This is a rather hackish way of invalidating indexes.
+    //        It would be good if GUI::Model had a way to orchestrate removal/insertion while preserving indexes.
+    did_update(previous_pid_count == m_pids.size() ? GUI::Model::UpdateFlag::DontInvalidateIndexes : GUI::Model::UpdateFlag::InvalidateAllIndexes);
 }