0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-15 19:21:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibJS: Remove no-op SymbolPrototype::description_setter()

Browse source 
We can just give put_native_property() a nullptr for the setter.
This commit is contained in:
Linus Groh 2020-05-18 01:00:09 +01:00 committed by Andreas Kling
parent 50c116e57b
commit b8b7f84547
Notes: sideshowbarker 2024-07-19 06:32:29 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/b8b7f84547a
Pull-request: https://github.com/SerenityOS/serenity/pull/2271
2 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibJS/Runtime/SymbolPrototype.cpp
View file

@ -42,8 +42,7 @@ namespace JS {
SymbolPrototype::SymbolPrototype()
: Object(interpreter().global_object().object_prototype())
{
// FIXME: description has no setter, eventually remove
put_native_property("description", description_getter, description_setter, Attribute::Configurable);
put_native_property("description", description_getter, nullptr, Attribute::Configurable);
put_native_function("toString", to_string, 0, Attribute::Writable | Attribute::Configurable);
put_native_function("valueOf", value_of, 0, Attribute::Writable | Attribute::Configurable);
@ -73,11 +72,6 @@ Value SymbolPrototype::description_getter(Interpreter& interpreter)
return js_string(interpreter, this_object->description());
}
void SymbolPrototype::description_setter(Interpreter&, Value)
{
// No-op, remove eventually
}
Value SymbolPrototype::to_string(Interpreter& interpreter)
{
auto* this_object = this_symbol_from_interpreter(interpreter);

1
Libraries/LibJS/Runtime/SymbolPrototype.h
View file

@ -39,7 +39,6 @@ private:
virtual const char* class_name() const override { return "SymbolPrototype"; }
static Value description_getter(Interpreter&);
static void description_setter(Interpreter&, Value);
static Value to_string(Interpreter&);
static Value value_of(Interpreter&);