瀏覽代碼

LibGUI: Make some GUI event getters return const references

There's no good reason to return rects/sizes/positions by value.
Andreas Kling 4 年之前
父節點
當前提交
b78e13cf2e
共有 1 個文件被更改,包括 7 次插入7 次删除
  1. 7 7
      Libraries/LibGUI/Event.h

+ 7 - 7
Libraries/LibGUI/Event.h

@@ -132,8 +132,8 @@ public:
 
 
     int parent_client_id() const { return m_parent_client_id; }
     int parent_client_id() const { return m_parent_client_id; }
     int parent_window_id() const { return m_parent_window_id; }
     int parent_window_id() const { return m_parent_window_id; }
-    String title() const { return m_title; }
-    Gfx::IntRect rect() const { return m_rect; }
+    const String& title() const { return m_title; }
+    const Gfx::IntRect& rect() const { return m_rect; }
     bool is_active() const { return m_active; }
     bool is_active() const { return m_active; }
     bool is_modal() const { return m_modal; }
     bool is_modal() const { return m_modal; }
     WindowType window_type() const { return m_window_type; }
     WindowType window_type() const { return m_window_type; }
@@ -162,7 +162,7 @@ public:
     {
     {
     }
     }
 
 
-    Gfx::IntRect rect() const { return m_rect; }
+    const Gfx::IntRect& rect() const { return m_rect; }
 
 
 private:
 private:
     Gfx::IntRect m_rect;
     Gfx::IntRect m_rect;
@@ -195,7 +195,7 @@ public:
     }
     }
 
 
     const Vector<Gfx::IntRect, 32>& rects() const { return m_rects; }
     const Vector<Gfx::IntRect, 32>& rects() const { return m_rects; }
-    Gfx::IntSize window_size() const { return m_window_size; }
+    const Gfx::IntSize& window_size() const { return m_window_size; }
 
 
 private:
 private:
     Vector<Gfx::IntRect, 32> m_rects;
     Vector<Gfx::IntRect, 32> m_rects;
@@ -211,8 +211,8 @@ public:
     {
     {
     }
     }
 
 
-    Gfx::IntRect rect() const { return m_rect; }
-    Gfx::IntSize window_size() const { return m_window_size; }
+    const Gfx::IntRect& rect() const { return m_rect; }
+    const Gfx::IntSize& window_size() const { return m_window_size; }
 
 
 private:
 private:
     Gfx::IntRect m_rect;
     Gfx::IntRect m_rect;
@@ -323,7 +323,7 @@ public:
     {
     {
     }
     }
 
 
-    Gfx::IntPoint position() const { return m_position; }
+    const Gfx::IntPoint& position() const { return m_position; }
     int x() const { return m_position.x(); }
     int x() const { return m_position.x(); }
     int y() const { return m_position.y(); }
     int y() const { return m_position.y(); }
     MouseButton button() const { return m_button; }
     MouseButton button() const { return m_button; }