Browse Source

Kernel+LibC: Pack SC_inode_watcher_add_watch_params struct better

Flagged by pvs-studio, ordering the members from largest to smallest
allows us to save a few bytes in the size of the struct.
Brian Gianforcaro 3 years ago
parent
commit
b45ca5d56e
2 changed files with 2 additions and 2 deletions
  1. 1 1
      Kernel/API/Syscall.h
  2. 1 1
      Userland/Libraries/LibC/fcntl.cpp

+ 1 - 1
Kernel/API/Syscall.h

@@ -474,8 +474,8 @@ struct SC_set_coredump_metadata_params {
 };
 
 struct SC_inode_watcher_add_watch_params {
-    int fd;
     StringArgument user_path;
+    int fd;
     u32 event_mask;
 };
 

+ 1 - 1
Userland/Libraries/LibC/fcntl.cpp

@@ -32,7 +32,7 @@ int create_inode_watcher(unsigned flags)
 
 int inode_watcher_add_watch(int fd, const char* path, size_t path_length, unsigned event_mask)
 {
-    Syscall::SC_inode_watcher_add_watch_params params { fd, { path, path_length }, event_mask };
+    Syscall::SC_inode_watcher_add_watch_params params { { path, path_length }, fd, event_mask };
     int rc = syscall(SC_inode_watcher_add_watch, &params);
     __RETURN_WITH_ERRNO(rc, rc, -1);
 }