0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Tests: Reduce runtime of TestCharacterTypes

Browse source 
This declares all test cases which compare function outputs over the
entire Unicode range as `BENCHMARK_CASE`, to avoid them being run by CI.
This reduces runtime of TestCharacterTypes (without benchmarks) by about
one third.
This commit is contained in:
Max Wipfli 2021-06-24 09:00:52 +02:00 • committed by Andreas Kling
parent ac650d2362
commit b3c3b78b01
Notes: sideshowbarker 2024-07-18 11:36:17 +09:00
1 changed files with 18 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
Tests/AK/TestCharacterTypes.cpp
View file

@ -34,10 +34,7 @@ void compare_value_output_over(u32 range, auto& old_function, auto& new_function
}
}
TEST_CASE(is_ascii)
{
compare_bool_output_over(UNICODE, isascii, is_ascii);
}
// NOTE: Avoid comparing over UNICODE in "TEST_CASE" due to test runtime becoming too long.
TEST_CASE(is_ascii_alphanumeric)
{
@ -101,12 +98,12 @@ TEST_CASE(is_ascii_upper_alpha)
TEST_CASE(to_ascii_lowercase)
{
compare_value_output_over(UNICODE, tolower, to_ascii_lowercase);
compare_value_output_over(ASCII, tolower, to_ascii_lowercase);
}
TEST_CASE(to_ascii_uppercase)
{
compare_value_output_over(UNICODE, toupper, to_ascii_uppercase);
compare_value_output_over(ASCII, toupper, to_ascii_uppercase);
}
TEST_CASE(parse_ascii_digit)
@ -133,3 +130,18 @@ TEST_CASE(parse_ascii_hex_digit)
return Test::Crash::Failure::DidNotCrash;
});
}
BENCHMARK_CASE(is_ascii)
{
compare_bool_output_over(UNICODE, isascii, is_ascii);
}
BENCHMARK_CASE(to_ascii_lowercase_unicode)
{
compare_value_output_over(UNICODE, tolower, to_ascii_lowercase);
}
BENCHMARK_CASE(to_ascii_uppercase_unicode)
{
compare_value_output_over(UNICODE, toupper, to_ascii_uppercase);
}