0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibVT: Handle non file urls in on hover tooltips

Browse source 
Previously we would simply compute the basename of the hovered url's
path and display it as the resource that will be opened. This patch adds
a fallback for non file urls to simply show the full url, making http
urls show up properly.
This commit is contained in:
networkException 2022-09-04 22:20:16 +02:00 • committed by Linus Groh
parent 4abb4317aa
commit b29fbe96dd
Notes: sideshowbarker 2024-07-17 07:31:32 +09:00
1 changed files with 15 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
Userland/Libraries/LibVT/TerminalWidget.cpp
View file

@ -831,13 +831,22 @@ void TerminalWidget::mousemove_event(GUI::MouseEvent& event)
auto handlers = Desktop::Launcher::get_handlers_for_url(attribute.href);
if (!handlers.is_empty()) {
auto path = URL(attribute.href).path();
auto name = LexicalPath::basename(path);
if (path == handlers[0]) {
set_tooltip(String::formatted("Execute {}", name));
auto url = URL(attribute.href);
auto path = url.path();
auto app_file = Desktop::AppFile::get_for_app(LexicalPath::basename(handlers[0]));
auto app_name = app_file->is_valid() ? app_file->name() : LexicalPath::basename(handlers[0]);
if (url.scheme() == "file") {
auto file_name = LexicalPath::basename(path);
if (path == handlers[0]) {
set_tooltip(String::formatted("Execute {}", app_name));
} else {
set_tooltip(String::formatted("Open {} with {}", file_name, app_name));
}
} else {
auto af = Desktop::AppFile::get_for_app(LexicalPath::basename(handlers[0]));
set_tooltip(String::formatted("Open {} with {}", name, af->is_valid() ? af->name() : LexicalPath::basename(handlers[0])));
set_tooltip(String::formatted("Open {} with {}", attribute.href, app_name));
}
}
} else {