0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibGfx: Use VERIFY_NOT_REACHED() for impossible states in ICC code

Browse source 
The `parse_` functions reject invalid values, so we know the default is
unreachable.
This commit is contained in:
Nico Weber 2022-12-31 11:49:57 -05:00 • committed by Tim Flynn
parent a8ee5dd9cd
commit b1e977e18a
Notes: sideshowbarker 2024-07-17 02:22:11 +09:00
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibGfx/ICCProfile.cpp
View file

@ -208,9 +208,8 @@ StringView device_class_name(DeviceClass device_class)
return "Abstract"sv;
case DeviceClass::NamedColor:
return "NamedColor"sv;
default:
return "(unknown device class)"sv;
}
VERIFY_NOT_REACHED();
}
StringView color_space_name(ColorSpace color_space)
@ -266,9 +265,8 @@ StringView color_space_name(ColorSpace color_space)
return "14 color"sv;
case ColorSpace::FifteenColor:
return "15 color"sv;
default:
return {};
}
VERIFY_NOT_REACHED();
}
StringView rendering_intent_name(RenderingIntent rendering_intent)
@ -282,9 +280,8 @@ StringView rendering_intent_name(RenderingIntent rendering_intent)
return "Saturation"sv;
case RenderingIntent::ICCAbsoluteColorimetric:
return "ICC-absolute colorimetric"sv;
default:
return {};
}
VERIFY_NOT_REACHED();
}
ErrorOr<NonnullRefPtr<Profile>> Profile::try_load_from_externally_owned_memory(ReadonlyBytes bytes)