0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Kernel: Avoid redundant bool comparisons in Kernel::Thread

Browse source 
Two instances of comparing a bool with == true or == false, and one
instance where we can just return an expression instead of checking it
to return true on succeess and false on failure.
This commit is contained in:
Andrew Kaster 2021-10-31 16:52:43 -06:00 • committed by Andreas Kling
parent c9d1c12efa
commit b1d5d3cc34
Notes: sideshowbarker 2024-07-18 01:06:36 +09:00
2 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Kernel/Thread.cpp
View file

@ -792,9 +792,7 @@ bool Thread::should_ignore_signal(u8 signal) const
auto const& action = m_signal_action_data[signal];
if (action.handler_or_sigaction.is_null())
return default_signal_action(signal) == DefaultSignalAction::Ignore;
if ((sighandler_t)action.handler_or_sigaction.get() == SIG_IGN)
return true;
return false;
return ((sighandler_t)action.handler_or_sigaction.get() == SIG_IGN);
}
bool Thread::has_signal_handler(u8 signal) const
@ -1068,7 +1066,7 @@ void Thread::set_state(State new_state, u8 stop_signal)
} else if (previous_state == Stopped) {
m_stop_state = State::Invalid;
auto& process = this->process();
if (process.set_stopped(false) == true) {
if (process.set_stopped(false)) {
process.for_each_thread([&](auto& thread) {
if (&thread == this)
return;
@ -1092,7 +1090,7 @@ void Thread::set_state(State new_state, u8 stop_signal)
// We don't want to restore to Running state, only Runnable!
m_stop_state = previous_state != Running ? previous_state : Runnable;
auto& process = this->process();
if (process.set_stopped(true) == false) {
if (!process.set_stopped(true)) {
process.for_each_thread([&](auto& thread) {
if (&thread == this)
return;

2
Kernel/Thread.h
View file

@ -883,7 +883,7 @@ public:
// NOTE: this may execute on the same or any other processor!
SpinlockLocker scheduler_lock(g_scheduler_lock);
SpinlockLocker block_lock(m_block_lock);
if (m_blocker && timeout_unblocked.exchange(true) == false)
if (m_blocker && !timeout_unblocked.exchange(true))
unblock();
});
if (!timer_was_added) {