AK: Fix erroneous move operators for SinglyLinkedList

This patch provides a proper implementation of the move operator and delete the move assignment operator. Those operators were introduced in #11888
Author: https://github.com/LucasChollet Commit: https://github.com/SerenityOS/serenity/commit/b0d51a6f36a Pull-request: https://github.com/SerenityOS/serenity/pull/11908 Reviewed-by: https://github.com/ADKaster Reviewed-by: https://github.com/IdanHo Reviewed-by: https://github.com/awesomekling
2022-01-15 11:08:08 +01:00 · 2022-01-15 11:08:08 +01:00 · b0d51a6f36 · 2024-07-17 20:39:44 +09:00
commit b0d51a6f36
parent 589ebbc24e
1 changed files with 8 additions and 2 deletions
--- a/AK/SinglyLinkedList.h
+++ b/AK/SinglyLinkedList.h
@ -81,9 +81,15 @@ private:
 public:
    SinglyLinkedList() = default;
    SinglyLinkedList(const SinglyLinkedList& other) = delete;
-    SinglyLinkedList(SinglyLinkedList&&) = default;
+    SinglyLinkedList(SinglyLinkedList&& other)
+        : m_head(other.m_head)
+        , m_tail(other.m_tail)
+    {
+        other.m_head = nullptr;
+        other.m_tail = nullptr;
+    }
    SinglyLinkedList& operator=(const SinglyLinkedList& other) = delete;
-    SinglyLinkedList& operator=(SinglyLinkedList&&) = default;
+    SinglyLinkedList& operator=(SinglyLinkedList&&) = delete;

    ~SinglyLinkedList() { clear(); }