Просмотр исходного кода

LibWeb: Add some missing events in EventWrapperFactory

I noticed some events we being wrapped into a generic Event while
working on CustomEvent. This also adds PageTransitionEvent's
constructor to the WindowObject.

I'm not sure if this is all of them.
Luke Wilde 3 лет назад
Родитель
Сommit
b04fafee74

+ 12 - 5
Userland/Libraries/LibWeb/Bindings/EventWrapperFactory.cpp

@@ -9,20 +9,27 @@
 #include <LibWeb/Bindings/EventWrapperFactory.h>
 #include <LibWeb/Bindings/MessageEventWrapper.h>
 #include <LibWeb/Bindings/MouseEventWrapper.h>
+#include <LibWeb/Bindings/PageTransitionEventWrapper.h>
+#include <LibWeb/Bindings/ProgressEventWrapper.h>
+#include <LibWeb/Bindings/SubmitEventWrapper.h>
 
-namespace Web {
-namespace Bindings {
+namespace Web::Bindings {
 
 EventWrapper* wrap(JS::GlobalObject& global_object, DOM::Event& event)
 {
-    if (is<HTML::MessageEvent>(event))
-        return static_cast<MessageEventWrapper*>(wrap_impl(global_object, static_cast<HTML::MessageEvent&>(event)));
     if (is<HTML::CloseEvent>(event))
         return static_cast<CloseEventWrapper*>(wrap_impl(global_object, static_cast<HTML::CloseEvent&>(event)));
+    if (is<HTML::MessageEvent>(event))
+        return static_cast<MessageEventWrapper*>(wrap_impl(global_object, static_cast<HTML::MessageEvent&>(event)));
+    if (is<HTML::PageTransitionEvent>(event))
+        return static_cast<PageTransitionEventWrapper*>(wrap_impl(global_object, static_cast<HTML::PageTransitionEvent&>(event)));
+    if (is<HTML::SubmitEvent>(event))
+        return static_cast<SubmitEventWrapper*>(wrap_impl(global_object, static_cast<HTML::SubmitEvent&>(event)));
     if (is<UIEvents::MouseEvent>(event))
         return static_cast<MouseEventWrapper*>(wrap_impl(global_object, static_cast<UIEvents::MouseEvent&>(event)));
+    if (is<XHR::ProgressEvent>(event))
+        return static_cast<ProgressEventWrapper*>(wrap_impl(global_object, static_cast<XHR::ProgressEvent&>(event)));
     return static_cast<EventWrapper*>(wrap_impl(global_object, event));
 }
 
 }
-}

+ 3 - 0
Userland/Libraries/LibWeb/Bindings/WindowObjectHelper.h

@@ -201,6 +201,8 @@
 #include <LibWeb/Bindings/MouseEventPrototype.h>
 #include <LibWeb/Bindings/NodeConstructor.h>
 #include <LibWeb/Bindings/NodePrototype.h>
+#include <LibWeb/Bindings/PageTransitionEventConstructor.h>
+#include <LibWeb/Bindings/PageTransitionEventPrototype.h>
 #include <LibWeb/Bindings/PerformanceConstructor.h>
 #include <LibWeb/Bindings/PerformancePrototype.h>
 #include <LibWeb/Bindings/PerformanceTimingConstructor.h>
@@ -353,6 +355,7 @@
     ADD_WINDOW_OBJECT_INTERFACE(MessageEvent)              \
     ADD_WINDOW_OBJECT_INTERFACE(MouseEvent)                \
     ADD_WINDOW_OBJECT_INTERFACE(Node)                      \
+    ADD_WINDOW_OBJECT_INTERFACE(PageTransitionEvent)       \
     ADD_WINDOW_OBJECT_INTERFACE(Performance)               \
     ADD_WINDOW_OBJECT_INTERFACE(PerformanceTiming)         \
     ADD_WINDOW_OBJECT_INTERFACE(ProcessingInstruction)     \

+ 2 - 0
Userland/Libraries/LibWeb/Forward.h

@@ -178,6 +178,8 @@ class ImageData;
 class MessageChannel;
 class MessageEvent;
 class MessagePort;
+class PageTransitionEvent;
+class SubmitEvent;
 class WebSocket;
 }