0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-11 17:00:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Userland+Base: Don't run NetworkSettings in elevated mode

Browse source
This commit is contained in:
Fabian Dellwing 2023-04-27 21:09:31 +02:00 committed by Andrew Kaster
parent 24b1bdca27
commit b01fcccbbd
Notes: sideshowbarker 2024-07-17 06:45:52 +09:00 
Author: https://github.com/fdellwing
Commit: https://github.com/SerenityOS/serenity/commit/b01fcccbbd
Pull-request: https://github.com/SerenityOS/serenity/pull/18545
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/BenWiederhake
Reviewed-by: https://github.com/LucasChollet
Reviewed-by: https://github.com/kennethmyhra
Reviewed-by: https://github.com/trflynn89
4 changed files with 2 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Base/res/apps/NetworkSettings.af
View file

@ -1,7 +1,6 @@
[App]
Name=Network Settings
Executable=/bin/NetworkSettings
RequiresRoot=true
Category=Settings
Description=Configure network connections
ExcludeFromSystemMenu=true

8
Userland/Applications/NetworkSettings/main.cpp
View file

@ -6,9 +6,6 @@
#include "NetworkSettingsWidget.h"
#include <LibCore/ArgsParser.h>
#include <LibGUI/MessageBox.h>
#include <unistd.h>
#include <LibCore/System.h>
#include <LibGUI/Application.h>
#include <LibGUI/Icon.h>
@ -35,11 +32,6 @@ ErrorOr<int> serenity_main(Main::Arguments args)
auto app = TRY(GUI::Application::create(args));
if (getuid() != 0) {
GUI::MessageBox::show_error(nullptr, "You need to be root to run Network Settings!"sv);
return 1;
}
TRY(Core::System::pledge("stdio rpath wpath cpath recvfd sendfd proc exec"));
auto app_icon = GUI::Icon::default_icon("network"sv);

2
Userland/Applications/SystemMonitor/NetworkStatisticsWidget.cpp
View file

@ -76,7 +76,7 @@ NetworkStatisticsWidget::NetworkStatisticsWidget()
"Open in Network Settings...", MUST(Gfx::Bitmap::load_from_file("/res/icons/16x16/network.png"sv)), [this](GUI::Action&) {
m_adapter_table_view->selection().for_each_index([this](GUI::ModelIndex const& index) {
auto adapter_name = index.sibling_at_column(1).data().as_string();
GUI::Process::spawn_or_show_error(window(), "/bin/Escalator"sv, Array { "/bin/NetworkSettings", adapter_name.characters() });
GUI::Process::spawn_or_show_error(window(), "/bin/NetworkSettings"sv, Array { adapter_name.characters() });
});
},
this));

1
Userland/Applications/SystemMonitor/main.cpp
View file

@ -248,6 +248,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
TRY(Core::System::unveil("/dev", "r"));
TRY(Core::System::unveil("/bin", "r"));
TRY(Core::System::unveil("/bin/Escalator", "x"));
TRY(Core::System::unveil("/bin/NetworkSettings", "x"));
TRY(Core::System::unveil("/usr/lib", "r"));
// This directory only exists if ports are installed