Quellcode durchsuchen

LibMarkdown: Don't put a newline in empty code blocks

This doesn't actually matter, but I'm trying to match the commonmark
test cases where possible.
Peter Elliott vor 3 Jahren
Ursprung
Commit
aef5aac772
1 geänderte Dateien mit 3 neuen und 10 gelöschten Zeilen
  1. 3 10
      Userland/Libraries/LibMarkdown/CodeBlock.cpp

+ 3 - 10
Userland/Libraries/LibMarkdown/CodeBlock.cpp

@@ -34,7 +34,7 @@ String CodeBlock::render_to_html(bool) const
     else
     else
         builder.append(escape_html_entities(m_code));
         builder.append(escape_html_entities(m_code));
 
 
-    builder.append("\n</code>");
+    builder.append("</code>");
 
 
     if (m_style.length() >= 2)
     if (m_style.length() >= 2)
         builder.append("</strong>");
         builder.append("</strong>");
@@ -142,7 +142,6 @@ OwnPtr<CodeBlock> CodeBlock::parse_backticks(LineIterator& lines)
 
 
     ++lines;
     ++lines;
 
 
-    bool first = true;
     StringBuilder builder;
     StringBuilder builder;
 
 
     while (true) {
     while (true) {
@@ -157,11 +156,8 @@ OwnPtr<CodeBlock> CodeBlock::parse_backticks(LineIterator& lines)
             if (close_fence[0] == fence[0] && close_fence.length() >= fence.length())
             if (close_fence[0] == fence[0] && close_fence.length() >= fence.length())
                 break;
                 break;
         }
         }
-
-        if (!first)
-            builder.append('\n');
         builder.append(line);
         builder.append(line);
-        first = false;
+        builder.append('\n');
     }
     }
 
 
     return make<CodeBlock>(language, style, builder.build());
     return make<CodeBlock>(language, style, builder.build());
@@ -169,7 +165,6 @@ OwnPtr<CodeBlock> CodeBlock::parse_backticks(LineIterator& lines)
 
 
 OwnPtr<CodeBlock> CodeBlock::parse_indent(LineIterator& lines)
 OwnPtr<CodeBlock> CodeBlock::parse_indent(LineIterator& lines)
 {
 {
-    bool first = true;
     StringBuilder builder;
     StringBuilder builder;
 
 
     while (true) {
     while (true) {
@@ -184,10 +179,8 @@ OwnPtr<CodeBlock> CodeBlock::parse_indent(LineIterator& lines)
         line = line.substring_view(prefix_length.value());
         line = line.substring_view(prefix_length.value());
         ++lines;
         ++lines;
 
 
-        if (!first)
-            builder.append('\n');
         builder.append(line);
         builder.append(line);
-        first = false;
+        builder.append('\n');
     }
     }
 
 
     return make<CodeBlock>("", "", builder.build());
     return make<CodeBlock>("", "", builder.build());