Explorar o código

Kernel: Remove FIXME about unsurfaced error and log something

If something goes wrong when trying to write out a perfcore file during
process finalization, there's nowhere to report an error to, other than
the debug log. So write it to the debug log.
Andreas Kling %!s(int64=4) %!d(string=hai) anos
pai
achega
ac8fe3d062
Modificáronse 1 ficheiros con 4 adicións e 2 borrados
  1. 4 2
      Kernel/Process.cpp

+ 4 - 2
Kernel/Process.cpp

@@ -597,9 +597,11 @@ void Process::finalize()
         if (!description_or_error.is_error()) {
             auto& description = description_or_error.value();
             auto json = m_perf_event_buffer->to_json(m_pid, m_executable ? m_executable->absolute_path() : "");
-            // FIXME: Should this error path be surfaced somehow?
             auto json_buffer = UserOrKernelBuffer::for_kernel_buffer(json.data());
-            (void)description->write(json_buffer, json.size());
+            auto result = description->write(json_buffer, json.size());
+            if (result.is_error()) {
+                dbgln("Error while writing perfcore file: {}", result.error().error());
+            }
         }
     }