0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibWeb: Restrict HTMLTextAreaElement::max_length to the range of i32

Browse source
This commit is contained in:
Tim Ledbetter 2024-11-30 21:57:18 +00:00 • committed by Andreas Kling
parent bc484258c2
commit ac7fad52f6
Notes: github-actions[bot] 2024-12-02 09:26:54 +00:00
3 changed files with 20 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/HTML/HTMLTextAreaElement.cpp
View file

@ -259,7 +259,7 @@ WebIDL::Long HTMLTextAreaElement::max_length() const
{
// The maxLength IDL attribute must reflect the maxlength content attribute, limited to only non-negative numbers.
if (auto maxlength_string = get_attribute(HTML::AttributeNames::maxlength); maxlength_string.has_value()) {
if (auto maxlength = parse_non_negative_integer(*maxlength_string); maxlength.has_value())
if (auto maxlength = parse_non_negative_integer(*maxlength_string); maxlength.has_value() && *maxlength <= 2147483647)
return *maxlength;
}
return -1;

18
Tests/LibWeb/Text/expected/HTML/unsigned-long-reflection.txt
View file

@ -253,6 +253,24 @@ select.getAttribute("size") after select.setAttribute("size", "4294967295"): 429
select.size after select.setAttribute("size", "4294967295"): 0
select.getAttribute("size") after select.size = 4294967295: 0
select.size after select.size = 4294967295: 0
textarea.getAttribute("minlength") after textarea.setAttribute("minLength", "0"): 0
textarea.minLength after textarea.setAttribute("minlength", "0"): 0
textarea.getAttribute("minlength") after textarea.minLength = 0: 0
textarea.minLength after textarea.minLength = 0: 0
textarea.getAttribute("minlength") after textarea.setAttribute("minLength", "1"): 1
textarea.minLength after textarea.setAttribute("minlength", "1"): 1
textarea.getAttribute("minlength") after textarea.minLength = 1: 1
textarea.minLength after textarea.minLength = 1: 1
textarea.getAttribute("minlength") after textarea.setAttribute("minLength", "2147483647"): 2147483647
textarea.minLength after textarea.setAttribute("minlength", "2147483647"): 2147483647
textarea.getAttribute("minlength") after textarea.minLength = 2147483647: 2147483647
textarea.minLength after textarea.minLength = 2147483647: 2147483647
textarea.getAttribute("minlength") after textarea.setAttribute("minLength", "2147483648"): 2147483648
textarea.minLength after textarea.setAttribute("minlength", "2147483648"): -2147483648
textarea.minLength = 2147483648 threw exception of type IndexSizeError
textarea.getAttribute("minlength") after textarea.setAttribute("minLength", "4294967295"): 4294967295
textarea.minLength after textarea.setAttribute("minlength", "4294967295"): -1
textarea.minLength = 4294967295 threw exception of type IndexSizeError
textarea.getAttribute("rows") after textarea.setAttribute("rows", "0"): 0
textarea.rows after textarea.setAttribute("rows", "0"): 2
textarea.getAttribute("rows") after textarea.rows = 0: 2

1
Tests/LibWeb/Text/input/HTML/unsigned-long-reflection.html
View file

@ -55,6 +55,7 @@
testProperty("marquee", "scrollAmount", (marquee) => marquee.scrollAmount, (marquee, value) => marquee.scrollAmount = value);
testProperty("marquee", "scrollDelay", (marquee) => marquee.scrollDelay, (marquee, value) => marquee.scrollDelay = value);
testProperty("select", "size", (select) => select.size, (select, value) => select.size = value);
testProperty("textarea", "minLength", (textarea) => textarea.minLength, (textarea, value) => textarea.minLength = value);
testProperty("textarea", "rows", (textarea) => textarea.rows, (textarea, value) => textarea.rows = value);
testProperty("textarea", "cols", (textarea) => textarea.cols, (textarea, value) => textarea.cols = value);
});